assert: allow updating expected vars/consts inside functions #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
|
Thank you for the PR! I was hoping to add support for this. I'll get CI working again and have a look at the change in more detail in the next few days |
dnephin
approved these changes
Sep 25, 2022
Member
dnephin
left a comment
dnephin
left a comment
There was a problem hiding this comment.
Not sure why the CI run failed, it's working for me now.
This looks great! I pushed one small commit to rename a function to reflect the new return value.
Thanks again for the PR!
dnephin
force-pushed
the
update-expected-inside-func
branch
2 times, most recently
from
f6fe867 to
b40de99
Compare
dnephin
force-pushed
the
update-expected-inside-func
branch
from
b40de99 to
4c65207
Compare
Contributor
Author
|
Thank you for quick merge! Looking forward to a new release 😋 |
This was referenced Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for such useful library. I was reading source and found
-updateflag to update the test code itself with "expectedXXX"-named variables. This was what I just wanted. Cool!Currently the source-update functionality only supports toplevel names. This PR changes this behavior to rewrite vars/consts which resides deeper scope.