feat: adding configuration to provide exclusion for failOnError with http post processor #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavkesh
reviewed
Jul 31, 2023
| return !getExcludeFailOnErrorCodes(httpSourceConfig.getExcludeFailOnErrorsCodeRange()).contains(statusCode); | ||
| } | ||
|
|
||
| private HashSet<Integer> getExcludeFailOnErrorCodes(String input) { |
Member
There was a problem hiding this comment.
We should save the list of error codes and not generate for every response. the list can be created and saved outside of the Response Handler.
lavkesh
reviewed
Jul 31, 2023
| postResponseTelemetry.validateResponseCode(meterStatsManager, statusCode); | ||
| failureHandler("Received status code : " + statusCode); | ||
| boolean shouldFailOnError = (httpSourceConfig.isFailOnErrors() ? shouldFailOnError(statusCode) : false); | ||
| failureHandler("Received status code : " + statusCode, shouldFailOnError); |
Member
There was a problem hiding this comment.
i would suggest to keep the method signature same.
and in line 131 do
if(shouldFailOnError(statusCode)) {
...
}
then the method sholdFailOnError will do the necessary checks.
lavkesh
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Added exclusion range with fail_on_errors for HTTP post-processors
GTF side we have some use cases where we must ignore some of the HTTP response codes when fail_on_errors is true.