chore: add keepalive time and keepalive timeout for grpc external processor #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsushmith
reviewed
Aug 29, 2023
...ore/src/main/java/com/gotocompany/dagger/core/processors/external/grpc/GrpcSourceConfig.java
Show resolved
Hide resolved
krishnaprasadas
suggested changes
Aug 31, 2023
...ore/src/main/java/com/gotocompany/dagger/core/processors/external/grpc/GrpcSourceConfig.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/com/gotocompany/dagger/core/processors/external/grpc/client/GrpcClient.java
Outdated
Show resolved
Hide resolved
manigandand
approved these changes
Apr 15, 2024
rajuGT
approved these changes
Apr 15, 2024
mayankrai09
force-pushed
the
chore/keepalive
branch
from
9d9e1dd to
5555697
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding capabilities to configure keepalive_time and keepalive_timeout for grpc external post-processor.
Linux by default has a mechanism to detect less-clean failure (half-open connection) with net.ipv4.tcp_retries2. This has a default value of 15. Only when that number is reached, the OS will forcefully terminate the “half-open” connection and force the connection to be recreated.
keepalive_time and keepalive_timeout helps early identify half-open connection.