shader,validation,expression,call,builtin,clamp:low_high:* appear invalid for override expression

[mwyrzykowski]

The WGSL specification says 8.1.2:

Otherwise, an override-expression E will be evaluated if and only if:

E forms part of the shader for the entry point specified by the GPUProgrammableStage, and:
Any of the following are true:

However the source for this test

cts/src/webgpu/shader/validation/expression/call/builtin/clamp.spec.ts

Line 94 in eb9091d

g.test('low_high')

onst wgsl = `
${enable}
override o_low : ${scalar};
override o_high : ${scalar};
fn foo() {
  var v_low : ${t.params.type};
  var v_high : ${t.params.type};
  var v : ${t.params.type};
  let tmp = clamp(v, ${low_arg}, ${high_arg});
}`;
    const error = t.params.low > t.params.high;
    const shader_error =
      error && t.params.lowStage === 'constant' && t.params.highStage === 'constant';
    const pipeline_error =
      t.params.in_shader &&
      error &&
      t.params.lowStage !== 'runtime' &&
      t.params.highStage !== 'runtime';
    t.expectCompileResult(!shader_error, wgsl);
    if (!shader_error) {
      const constants: Record<string, number> = {};
      constants['o_low'] = t.params.low;
      constants['o_high'] = t.params.high;
      t.expectPipelineResult({
        expectedResult: !pipeline_error,
        code: wgsl,
        constants,
        reference: ['o_low', 'o_high'],
        statements: t.params.in_shader ? ['foo();'] : [],
      });
    }

and then checking the definition of expectPipelineResult:

const code =
      args.code +
      (args.addWorkgroupSize !== false
        ? `
@workgroup_size(1)`
        : ``) +
      `
      @compute fn main() {
  ${phonies.join('\n')}
}

I.e., foo is not an entry point as defined in the specification:

To create an entry point, declare a user-defined function with a shader stage attribute.

but rather main is

[mwyrzykowski]

cc @greggman @dneto0 - I tried to make a PR but it looks like I may have lost access to pushing branches:

 % git push --set-upstream origin eng/mikew/fix-4588
Enumerating objects: 19, done.
Counting objects: 100% (19/19), done.
Delta compression using up to 24 threads
Compressing objects: 100% (9/9), done.
Writing objects: 100% (10/10), 1.87 KiB | 1.87 MiB/s, done.
Total 10 (delta 8), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (8/8), completed with 8 local objects.
remote: error: GH013: Repository rule violations found for refs/heads/eng/mikew/fix-4588.
remote: Review all repository rules at https://github.com/gpuweb/cts/rules?ref=refs%2Fheads%2Feng%2Fmikew%2Ffix-4588
remote: 
remote: - Cannot create ref due to creations being restricted.
remote: 
To https://github.com/gpuweb/cts.git
 ! [remote rejected]         eng/mikew/fix-4588 -> eng/mikew/fix-4588 (push declined due to repository rule violations)
error: failed to push some refs to 'https://github.com/gpuweb/cts.git'

Though also I imagine the intent here is to actually test the override behavior as part of an entry point but I don't think that is occurring now

[kainino0x]

We have branch rules that prevent creating new branches inside the repository to avoid accidentally cluttering the repo. You need to make a fork on GitHub and push your branch to that.