Use environment variables to configure Gradle init scripts #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System properties cannot be reliably read from init scripts in certain versions of Gradle. This is not the case for environment variables.
Member
Author
|
Successful cross platform test run: https://github.com/gradle/gradle-enterprise-build-validation-scripts/actions/runs/11686512948/job/32542510765 |
jprinet
approved these changes
Nov 5, 2024
Member
jprinet
left a comment
jprinet
left a comment
There was a problem hiding this comment.
Thanks for the super quick fix!
One little concern for Windows environment 😛
jthurne
reviewed
Nov 5, 2024
jthurne
approved these changes
Nov 5, 2024
Member
|
@erichaagdev Regarding System properties cannot be read reliably from init scripts for older versions of Gradle.: I don’t agree with that. It’s only since changing to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System properties cannot be read reliably from init scripts for older versions of Gradle. This is not the case for environment variables. This PR changes the configuration of the init scripts to be done using environment variables instead of system properties.