Skip to content

Conversation

@erichaagdev
Copy link
Member

@erichaagdev erichaagdev commented Nov 5, 2024

This PR adds an additional optional parameter to download the latest development release of the scripts. If left unspecified, the latest released version will be downloaded.

@erichaagdev erichaagdev requested a review from jprinet November 5, 2024 16:58
@erichaagdev erichaagdev self-assigned this Nov 5, 2024
Copy link
Member

@jprinet jprinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, we could run some gradle-enterprise based version or some develocity based version, which conditions the folder name containing the script.
This has to be addressed for each build tool and each experiments.
See as an example for Gradle on experiment 1 here and here

@erichaagdev
Copy link
Member Author

erichaagdev commented Nov 6, 2024

@jprinet that is a very good point. I see two options:

  1. Make this work for both DV and GE distributions, which will complicate logic a bit
  2. Change this approach to only expose an option to download the latest development version

I am leaning towards # 2 until we have a use case for # 1. So, we would have a boolean parameter like useDevelopmentVersion that's false by default and you would not have a way to control the version.

What do you think?

@jprinet
Copy link
Member

jprinet commented Nov 6, 2024

  1. Make this work for both DV and GE distributions, which will complicate logic a bit
  2. Change this approach to only expose an option to download the latest development version

I am leaning towards # 2 until we have a use case for # 1. So, we would have a boolean parameter like useDevelopmentVersion that's false by default and you would not have a way to control the version.

What do you think?

I agree with your proposal, this is what we want at the moment and it won't pollute all the composite actions with repeated tedious logic

@erichaagdev erichaagdev force-pushed the erichaagdev/add-download-version branch from 9fc3ee3 to 831909b Compare November 6, 2024 18:29
@erichaagdev erichaagdev changed the title Make the version of the scripts to download configurable in the download actions Expose option to download latest development release in the download actions Nov 6, 2024
@erichaagdev
Copy link
Member Author

@jprinet I've updated the PR according to our discussion.

Copy link
Member

@jprinet jprinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
There is a README page for each build tool, but I think it's fair to not document this parameter

@erichaagdev
Copy link
Member Author

Going to merge this.

@erichaagdev erichaagdev merged commit 52cde90 into main Nov 8, 2024
4 checks passed
@erichaagdev erichaagdev deleted the erichaagdev/add-download-version branch November 8, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants