update labels to current jsonnet-libs standard and fix dashboards #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafana/jsonnet-libs#261 updates labels to make instance labels unique. This commit sycnes with that change, but subsequently makes an overdue change by going through all the dashboards and fixing various issues with them. The new dashboards are compatible with the new labeling scheme, but also fix some problems: 1. Make sure the unloved Agent and Agent Prometheus Remote Write run correct queries and account for the instance_name labels 2. Use proper graph label values in Agent Operational 3. Allow to filter Agent Operational graph by container As part of making the Agent dashboard useful, a new metric has been added to track samples added to the WAL over time. Closes #73.
hoenn
approved these changes
May 28, 2020
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
grafana/jsonnet-libs#261 updates labels to make instance labels unique. This commit sycnes with that change, but subsequently makes an overdue change by going through all the dashboards and fixing various issues with them. The new dashboards are compatible with the new labeling scheme, but also fix some problems: 1. Make sure the unloved Agent and Agent Prometheus Remote Write run correct queries and account for the instance_name labels 2. Use proper graph label values in Agent Operational 3. Allow to filter Agent Operational graph by container As part of making the Agent dashboard useful, a new metric has been added to track samples added to the WAL over time. Closes #73.
wildum
pushed a commit
that referenced
this pull request
Apr 9, 2024
* Initial cleanup of Introduction topic * Replace river sytnax highlighting with alloy syntax highlighting * Remove a few instances of agent * Restore BoringCrypto as it's tracked in another PR
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grafana/jsonnet-libs#261 updates labels to make instance labels unique. This commit sycnes with that change, but subsequently makes an overdue change by going through all the dashboards and fixing various issues with them.
The new dashboards are compatible with the new labeling scheme, but also fixes some problems:
As part of making the Agent dashboard useful, a new metric has been added to track samples added to the WAL over time.
Closes #73.