Fix OATS workflow by martincostello · Pull Request #137 · grafana/grafana-opentelemetry-dotnet

martincostello · 2025-05-09T08:45:57Z

Changes

Upgrade Go to 1.24.
Remove permissions from all jobs.
Avoid warning if no error logs found.
Allow manual dispatch and run OATS for PRs.
Remove obsolete version property from docker compose files.
Update .NET container ports from 80 to 8080 (docs).
Expose port 1433 for SQL Server.
Update leftover reference to .NET 6.
Modernise Dockerfile for .NET 8+.
Ignore docker compose build files.
Fix/update OATS queries/assertions.
Move all OATS tests to a single file to reduce execution time from ~13m to ~4m.

Merge requirement checklist

Unit tests added/updated
CHANGELOG.md file updated for non-trivial changes
Changes in public API reviewed (if applicable)

martincostello · 2025-05-09T08:53:36Z

Hit my go knowledge wall here pretty fast 😅

@zeitlinger Is this something that needs fixing in the oats repo itself so the fix comes with the clone?

zeitlinger · 2025-05-12T08:07:07Z

Hit my go knowledge wall here pretty fast 😅

@zeitlinger Is this something that needs fixing in the oats repo itself so the fix comes with the clone?

This OATs setup is deprecated - not sure if the question still applies when updated.

This is my reference setup - where mise installs the oats binary directly.
You can also use go install - but you don't need ginkgo and file uploading any more.

martincostello · 2025-05-12T09:48:57Z

Ok cool, in that case I'll update this to use the other way when I get back to it.

martincostello · 2025-05-19T11:08:24Z

Depends on grafana/oats#109.

martincostello · 2025-06-02T16:31:29Z

OATS is basically working now - will rebase onto ~~#138 and~~ #139 once merged.

- Upgrade Go to 1.24. - Remove permissions from all jobs. - Avoid warning if no error logs found. - Allow manual dispatch.

Run `go mod tidy` to see if that fixes things.

Try running it later.

Just while I don't know what the real fix is.

Didn't fix it, but it's further along with the first one.

Install OATS directly instead of cloning.

Consume changes from grafana/oats#109 to fix matrix usage.

Remove obsolete `version` property.

Update from .NET 6 to .NET 8.

.NET 8 changed the default container port to `8080`.

Update commands to run OATS tests.

Map port 8080 for ASP.NET Core.

Add a PowerShell script to run the OATS tests locally cross-platform.

Set the executable bit for macOS and Linux.

Remove references to non-existent compose file.

Avoid prerelease versions of the .NET SDK if installed locally.

Fix (and simplify) the ASP.NET Core dockerfile.

Fix timeout no longer being consumed from `TESTCASE_TIMEOUT` env var and instead use `--timeout` flag.

Container name is `lgtm` not `container`.

Fix names based on docker-otel-lgtm's .NET example.

Fix self-contained publish not working due to quotes.

Add OTLP logging.

Add whitespace to make things more readable.

Add log query (which needs to be fixed).

Configure logging in the right way.

Fix metric names.

Fix trace query for `GetError`.

Use the latest stable release of OATS.

Expose port 1433 so that the application can connect to it.

Fix incorrect attributes.

Update traceql to match HTTP test cases.

Then we know if we break things.

- Use primary constructors. - Remove unused fields. - Use structured logging. - Use `await using`. - Use HttpClientFactory. - Use async methods where available. - Use collection expressions.

Use `span.http.route` instead of `name`.

Combine the OATS tests into a single file to speed up the execution time by avoiding spinning containers up and down so much.

Pin OATS to v0.3.2 and configure renovate.

Revert redundant change.

matt-hensley

martincostello commented Jun 2, 2025

View reviewed changes

Comment thread .github/workflows/oats.yml Outdated

martincostello force-pushed the fix-oats branch from 17cb0a2 to 5665041 Compare June 2, 2025 19:29

martincostello mentioned this pull request Jun 2, 2025

Refactor example app #139

Merged

martincostello added 22 commits June 4, 2025 15:04

Fix OATS workflow

40cead9

- Upgrade Go to 1.24. - Remove permissions from all jobs. - Avoid warning if no error logs found. - Allow manual dispatch.

Run go mod tidy

530104c

Run `go mod tidy` to see if that fixes things.

Move go mod tidy

c1a64d2

Try running it later.

Run go mod tidy twice

e302522

Just while I don't know what the real fix is.

Remove extra tidy

878b1dc

Didn't fix it, but it's further along with the first one.

Refactor workflow

2d2c038

Install OATS directly instead of cloning.

Use oats from fix PR

68ecfcc

Consume changes from grafana/oats#109 to fix matrix usage.

Fix compose warnings

ad4a001

Remove obsolete `version` property.

Fix dockerfile path

705d6cd

Update from .NET 6 to .NET 8.

Fix port mappings

7f144e0

.NET 8 changed the default container port to `8080`.

Update run-oats-tests.sh

e777ecb

Update commands to run OATS tests.

Add port mapping

33a5ae8

Map port 8080 for ASP.NET Core.

Add PowerShell file to run OATS

1c21abb

Add a PowerShell script to run the OATS tests locally cross-platform.

Set executable bit

8633dcd

Set the executable bit for macOS and Linux.

Remove non-existent file

5800601

Remove references to non-existent compose file.

Avoid prereleases

da01f34

Avoid prerelease versions of the .NET SDK if installed locally.

Fix Dockerfile

142dc00

Fix (and simplify) the ASP.NET Core dockerfile.

Fix timeout

6cb76a8

Fix timeout no longer being consumed from `TESTCASE_TIMEOUT` env var and instead use `--timeout` flag.

Fix collector address

aed8b1a

Container name is `lgtm` not `container`.

Fix trace queries

9684075

Fix names based on docker-otel-lgtm's .NET example.

Fix Dockerfile

ae01dbf

Fix self-contained publish not working due to quotes.

Add logging

48668df

Add OTLP logging.

martincostello added 14 commits June 4, 2025 15:04

Reformat example

fafd10b

Add whitespace to make things more readable.

Add log query

9e26c5b

Add log query (which needs to be fixed).

Fix logging

f313d70

Configure logging in the right way.

Fix metrics

85520e3

Fix metric names.

Fix trace query

b47eeac

Fix trace query for `GetError`.

Use latest OATS

703779a

Use the latest stable release of OATS.

Expose MSSQL port

4b892d5

Expose port 1433 so that the application can connect to it.

Fix SQL queries

b207d58

Fix incorrect attributes.

More trace fixes

0f6af28

Update traceql to match HTTP test cases.

Run for PRs

3c4e206

Then we know if we break things.

Refactor example

7dab385

- Use primary constructors. - Remove unused fields. - Use structured logging. - Use `await using`. - Use HttpClientFactory. - Use async methods where available. - Use collection expressions.

Fix Redis query

e3f4e49

Use `span.http.route` instead of `name`.

Combine OATS cases

549ed02

Combine the OATS tests into a single file to speed up the execution time by avoiding spinning containers up and down so much.

Resolve TODOs

df4cc92

Pin OATS to v0.3.2 and configure renovate.

martincostello force-pushed the fix-oats branch from 33ba73a to df4cc92 Compare June 4, 2025 14:04

martincostello marked this pull request as ready for review June 4, 2025 14:09

martincostello requested a review from a team as a code owner June 4, 2025 14:09

martincostello commented Jun 4, 2025

View reviewed changes

Comment thread examples/net8.0/aspnetcore/Controllers/RedisController.cs Outdated

Apply suggestions from code review

68a89e3

Revert redundant change.

martincostello enabled auto-merge (squash) June 4, 2025 14:17

matt-hensley approved these changes Jun 4, 2025

View reviewed changes

martincostello merged commit a646c7d into main Jun 4, 2025
10 checks passed

martincostello deleted the fix-oats branch June 4, 2025 16:10

This was referenced Aug 12, 2025

Bump Grafana.OpenTelemetry and Grafana.OpenTelemetry.Base aceralrighty/Polymod#152

Merged

Bump Grafana.OpenTelemetry.Base from 1.2.0 to 1.3.0 aceralrighty/Polymod#155

Merged

dependabot Bot mentioned this pull request Feb 20, 2026

Bump Grafana.OpenTelemetry from 1.2.0 to 1.5.2 BOLT04/grafana-observability-demo#67

Open

dependabot Bot mentioned this pull request May 4, 2026

chore: Bump coverlet.collector and 18 others jardimdesoftware/prontusvitale#187

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix OATS workflow#137

Fix OATS workflow#137
martincostello merged 37 commits intomainfrom
fix-oats

martincostello commented May 9, 2025 •

edited

Loading

Uh oh!

martincostello commented May 9, 2025

Uh oh!

zeitlinger commented May 12, 2025

Uh oh!

martincostello commented May 12, 2025

Uh oh!

martincostello commented May 19, 2025

Uh oh!

Uh oh!

martincostello commented Jun 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

matt-hensley left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

martincostello commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Merge requirement checklist

Uh oh!

martincostello commented May 9, 2025

Uh oh!

zeitlinger commented May 12, 2025

Uh oh!

martincostello commented May 12, 2025

Uh oh!

martincostello commented May 19, 2025

Uh oh!

Uh oh!

martincostello commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

matt-hensley left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

martincostello commented May 9, 2025 •

edited

Loading

martincostello commented Jun 2, 2025 •

edited

Loading