Fix constant condition CodeQL warnings#355
Merged
martincostello merged 1 commit intomainfrom Nov 24, 2025
Merged
Conversation
Remove redundant `if` blocks to resolve CodeQL warnings about constant conditions.
There was a problem hiding this comment.
Pull request overview
This PR removes redundant null checks in three extension methods that were causing CodeQL warnings about constant conditions. The changes simplify the code by removing unnecessary if blocks that checked for null before using the null-conditional operator ?..
- Removes redundant
if (configure != null)checks beforeconfigure?.Invoke(settings)calls - Applies the same fix consistently across three provider builder extensions
- No behavioral changes, as the null-conditional operator already handles null checking
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TracerProviderBuilderExtensions.cs | Removed redundant null check before invoking the configure callback in UseGrafana method |
| OpenTelemetryLoggerOptionsExtensions.cs | Removed redundant null check before invoking the configure callback in UseGrafana method |
| MeterProviderBuilderExtensions.cs | Removed redundant null check before invoking the configure callback in UseGrafana method |
matt-hensley
approved these changes
Nov 24, 2025
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Remove redundant
ifblocks to resolve CodeQL warnings about constant conditions.Merge requirement checklist
Unit tests added/updatedCHANGELOG.mdupdatedChanges in public API reviewed (if applicable)