-
Notifications
You must be signed in to change notification settings - Fork 176
Integrations common lib #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Integrations common lib #1028
Changes from 1 commit
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
3430ad1
Init lib
v-zhuravlev 5b574af
add grafonnet import
v-zhuravlev aac4467
Add panels in common lib
v-zhuravlev 6e6a921
Update Makefile
v-zhuravlev baf69ab
Add entrypoint for panels
v-zhuravlev e42c21b
Fix to v10.0.0
v-zhuravlev d7c45aa
Switch from function() to new()
v-zhuravlev 148a906
jsonnetfmt
v-zhuravlev 5e93a5f
Update stat panels
v-zhuravlev 947e73d
Drop fixed interval for all intervals
v-zhuravlev a775ca1
Shuffle lib structure and add comments
v-zhuravlev 2f4d4df
Update common-lib/common/panels.libsonnet
v-zhuravlev 853b407
Add cpu usage stat
v-zhuravlev 7fcb5f1
Add stylize function
v-zhuravlev ec9c420
Add cpu percentage
v-zhuravlev 3e4b5d0
Fix tooltip and legend
v-zhuravlev a2edc2e
Network base: withAxisCenteredZero when withNegateOutPackets
v-zhuravlev 7e9f32f
Fix timeSeries style
v-zhuravlev 5d48a2e
Fix reduceOptions:
v-zhuravlev b533802
DROP grafonnet inheritance for basic panels
v-zhuravlev 7966cdf
Add filesystem usage table
v-zhuravlev b1d644a
Add common annotation
v-zhuravlev 781c316
Add filesystem table with input validtion
v-zhuravlev 28b1fa9
Add threshold
v-zhuravlev e6a73d5
Add gradient 'scheme' to percentage
v-zhuravlev 1a95561
Add cpu.stat
v-zhuravlev 07c9360
update cpu.timeSeries
v-zhuravlev cc295d5
Add filesystems.stat
v-zhuravlev d4083ad
Upate network.timeSeries
v-zhuravlev 53493ed
Update disk.timeSeries
v-zhuravlev 90739d9
Update panels
v-zhuravlev bf5ac34
Add topkPercentage
v-zhuravlev 12e239e
Add table panels
v-zhuravlev 73d7cc0
Update to work with latest mixin
v-zhuravlev e0d04c3
Remove duplicated
v-zhuravlev c54fa7b
add panel wide datasource
v-zhuravlev 52a4583
add serviceFailed annotation
v-zhuravlev d8203a1
Add new annotations
v-zhuravlev 7570070
Add datalink to topk_percentage
v-zhuravlev 88a38dd
Update topk
v-zhuravlev 883e6f5
Fix 'all' panel
v-zhuravlev e18b1f6
Add util by mode
v-zhuravlev 643747a
switch to bytes from decbytes
v-zhuravlev ad669a8
Add statusHistory panel
v-zhuravlev 0e23766
Add disk panels
v-zhuravlev 382d45d
Add default descriptions
v-zhuravlev 974ff27
Merge disk and filesystem
v-zhuravlev fe90390
Remove bigger text in stat panels
v-zhuravlev 5a6d0b2
Fix disks styles
v-zhuravlev dd0e353
Remove unused
v-zhuravlev fb90335
Update memory panels
v-zhuravlev d1f4cc7
Fix disk usage table
v-zhuravlev f695413
Add utils (from windows lib)
v-zhuravlev 994137f
Add link to utils
v-zhuravlev f6758a1
Update panels
v-zhuravlev 6d3a42d
Add contrib
v-zhuravlev 7247c57
Rename 'all' to 'generic'
v-zhuravlev 2c9bbf5
Update panels
v-zhuravlev bc0fa62
Update ts stylize
v-zhuravlev ef263c4
Update stat panels stylize
v-zhuravlev 83b36a8
Fix ts stylize
v-zhuravlev cb1fb97
Add table
v-zhuravlev dede26b
Update status-history
v-zhuravlev 869f93d
Update README
v-zhuravlev b9aa2f1
lint-fmt
v-zhuravlev 6d776a3
Drop title from base class args
v-zhuravlev e1aa770
Update common-lib/common/panels/generic/base.libsonnet
v-zhuravlev cb079c6
Update common-lib/common/panels/generic/timeSeries/percentage.libsonnet
v-zhuravlev cfc250f
Remove comments
v-zhuravlev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update README
- Loading branch information
commit 869f93dbbf0d06522ea28f853bae9243b1b28634
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,20 @@ | ||
|
|
||
| ## Panels overview | ||
|
|
||
| All panels in this lib should implement one or more functions: | ||
| All panels in this lib should implement one of the following methods: | ||
|
|
||
| - panel.new(title,targets,description) - creates new panel. List of arguments could vary; | ||
| - panel.stylize() - directly applies this panel style to existing panel; | ||
| - panel.stylizeByRegexp(regexp) - attaches style as panel overrides (by regexp); | ||
| - panel.stylizeByName(name) - attaches style as panel overrides (by name); | ||
| - `panel.new(title,targets,description)` - creates new panel. List of arguments could vary; | ||
| - `panel.stylize(allLayers=true)` - directly applies this panel style to existing panel. By default includes all layers of styles. To apply only top layer, set allLayers=false. This mode is useful to cherry-pick style layers to create new style combination. | ||
|
|
||
| Some other methods could be found such as: | ||
| - `panel.stylizeByRegexp(regexp)` - attaches style as panel overrides (by regexp); | ||
| - `panel.stylizeByName(name)` - attaches style as panel overrides (by name). | ||
|
|
||
| ## Panels common groups | ||
|
|
||
| This library consists of multiple common groups of panels for widely used resources such as CPU, memory, disks and so on. | ||
|
|
||
| All of those groups inherit `generic` group as their base. | ||
|
|
||
| All panels should inherit `generic/base.libsonnet` via `generic/<paneltype>/base.libsonnet`. | ||
| All panels inherit `generic/base.libsonnet` via `generic/<paneltype>/base.libsonnet`. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we document the concept of "layers" here a bit more thoroughly? The concept is not immediately apparent from the
CONTRIB.mdorREADME.md.It looks like what is meant is if you, for example, apply stylize from
panels/network/timeseries/packets/, withallLayersyou will effectively apply not only the styles specific to a network packets timeseries (ingress above 0, egress below 0), but also the default style frompanels/generic/timeseries?Possibly an architecture diagram of the layout of this lib would be useful.
Also, I would advise that this get added to a follow-up PR, and we create an issue to track. No need to hold the merging of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct. I'll try to expand documentation once we came to terms.