Skip to content

Windows modular observ lib #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
v-zhuravlev merged 76 commits into from
Oct 18, 2023
Merged

Windows modular observ lib #1050

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
aeb5405
Add initial structure for windows modular mixin
v-zhuravlev Aug 29, 2023
1756c54
Add panels skeleton for main
v-zhuravlev Sep 1, 2023
0b737c0
Update main
v-zhuravlev Sep 4, 2023
39797eb
Update dashboards
v-zhuravlev Sep 4, 2023
ac17aae
Add new targets and panels
v-zhuravlev Sep 4, 2023
77121c1
Add more panels and targets
v-zhuravlev Sep 6, 2023
e4d13b8
Update to remote
v-zhuravlev Sep 6, 2023
6356289
Add overview panels and targets
v-zhuravlev Sep 7, 2023
e4f7067
Fix to work with latest grafonnet
v-zhuravlev Sep 8, 2023
23eaf04
Add loglib dashboard to pack
v-zhuravlev Sep 8, 2023
2570246
Fix uptime override in fleet table
v-zhuravlev Sep 8, 2023
3237531
Update refresh for vars
v-zhuravlev Sep 20, 2023
25ba2aa
Update windows logs format
v-zhuravlev Sep 20, 2023
e837279
Add optional logs annotations
v-zhuravlev Sep 21, 2023
21661b4
Add datalinks from fleet table
v-zhuravlev Sep 21, 2023
adc3d24
Add number of alertsCritical/alertsWarning to fleet table
v-zhuravlev Sep 21, 2023
17ab90f
Add grouplabels to reboot annotations
v-zhuravlev Sep 21, 2023
138b77b
Add drilldown links to topk panels
v-zhuravlev Sep 21, 2023
0d80c2b
jsonnet format
v-zhuravlev Sep 21, 2023
1106ec8
Update args
v-zhuravlev Sep 21, 2023
c2a43b6
Add system dashboard layout and timezone metric
v-zhuravlev Sep 21, 2023
49b5915
Add osTimezone target
v-zhuravlev Sep 21, 2023
7d6494b
Add cpu usage by mode
v-zhuravlev Sep 21, 2023
370fab5
Add cpuqueu
v-zhuravlev Sep 21, 2023
d6dc77a
Add cpu queue panel
v-zhuravlev Sep 21, 2023
f364d87
fmt main
v-zhuravlev Sep 22, 2023
2d64f40
add system panels
v-zhuravlev Sep 22, 2023
7aff434
Add alerts and refresh,period,timezone
v-zhuravlev Sep 22, 2023
105183e
Move lib to sep dir
v-zhuravlev Sep 22, 2023
393c872
Fmt
v-zhuravlev Sep 22, 2023
d3d2537
Switch mixin to use windows-observ-lib
v-zhuravlev Sep 22, 2023
7364671
Add alerts todo
v-zhuravlev Sep 22, 2023
d40b7c7
Add comments
v-zhuravlev Sep 22, 2023
9df70c8
move config to config.libsonnet (mixin style)
v-zhuravlev Sep 22, 2023
629fe87
Remove unused chart
v-zhuravlev Sep 22, 2023
100ce58
update jsonnetfile
v-zhuravlev Sep 22, 2023
2d6268e
Update links
v-zhuravlev Sep 22, 2023
e45f365
Add grafonnet dep
v-zhuravlev Sep 22, 2023
e4c123f
Add physical drive alert
v-zhuravlev Sep 22, 2023
0dbd65d
Update line format
v-zhuravlev Sep 22, 2023
cb9d5be
Update alerts 'for' durations
v-zhuravlev Sep 22, 2023
4de65df
Add disk and filesystem dashboard
v-zhuravlev Sep 22, 2023
cdcb124
Drop network dashboard
v-zhuravlev Sep 22, 2023
671e942
change default uids
v-zhuravlev Sep 22, 2023
8a05e8e
Update imports
v-zhuravlev Sep 22, 2023
5ee2e13
Add readme
v-zhuravlev Sep 22, 2023
f0a2d59
Update readme
v-zhuravlev Sep 22, 2023
45e21c0
Update logs config
v-zhuravlev Sep 22, 2023
ee8d8f2
fmt
v-zhuravlev Sep 22, 2023
d9d6b0b
Fix typo in readem
v-zhuravlev Sep 22, 2023
7c8dfd9
Add descriptions
v-zhuravlev Sep 27, 2023
09a9a47
Change logs datasource label
v-zhuravlev Sep 27, 2023
fc70723
Sentence case all labels and table column names
v-zhuravlev Sep 27, 2023
ebe8e0a
Fix customAllValue
v-zhuravlev Sep 27, 2023
30da9a6
Fix commonlib import
v-zhuravlev Sep 27, 2023
57877a6
Update jsonnet dep
v-zhuravlev Sep 27, 2023
b57302d
Update panels
v-zhuravlev Sep 27, 2023
3841f9a
Update version
v-zhuravlev Sep 27, 2023
b9708d4
Fmt
v-zhuravlev Sep 28, 2023
1ceebde
Add time collector tip in ntp panels
v-zhuravlev Sep 28, 2023
d4f3351
Revert commonlib link
v-zhuravlev Sep 28, 2023
e38a7fd
Adding NTP alerts.
gaantunes Oct 4, 2023
d66f682
Adding time offset alert
gaantunes Oct 5, 2023
9ca1340
Move utils to commonlib
v-zhuravlev Oct 5, 2023
409ce6a
Suggestions from Vitaly
gaantunes Oct 5, 2023
cb2e270
removing service not running metric.w
gaantunes Oct 5, 2023
e384c2b
lint fix
gaantunes Oct 6, 2023
b319c4a
Update variables
v-zhuravlev Oct 6, 2023
e30cf6f
Remove TODO notes
v-zhuravlev Oct 6, 2023
77994b1
Rename 'all' to 'generic'
v-zhuravlev Oct 10, 2023
e87b429
Rename to generic 2
v-zhuravlev Oct 10, 2023
6d58b00
Remove redundant uid
v-zhuravlev Oct 12, 2023
6fb794e
Drop unused label from reboot annotation
v-zhuravlev Oct 12, 2023
4332de9
Update observ lib 'schema'
v-zhuravlev Oct 13, 2023
c07cc92
Update jsonnet deps to main
v-zhuravlev Oct 18, 2023
1d0eb76
Update regex
v-zhuravlev Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update jsonnetfile
  • Loading branch information
@v-zhuravlev
v-zhuravlev committed Oct 18, 2023
commit 100ce588e75165f99d3e7ff0e52b0f68ea5276ab
14 changes: 3 additions & 11 deletions windows-mixin/jsonnetfile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,11 @@
{
"source": {
"git": {
"remote": "https://github.com/grafana/grafonnet-lib.git",
"subdir": "grafonnet"
"remote": "https://github.com/grafana/jsonnet-libs.git",
"subdir": "windows-observ-lib"
}
},
"version": "master"
},
{
"source": {
"local": {
"directory": "../windows-observ-lib"
}
},
"version": ""
"version": "vzhuravlev/jl-windows-new"
Copy link
Contributor

@rgeyer rgeyer Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to have a follow-up PR to change this to master, or perhaps you can reference the specific commit SHA. I believe the branch usually gets deleted on merge.

}
],
"legacyImports": true
Expand Down
7 changes: 4 additions & 3 deletions windows-observ-lib/jsonnetfile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@
"dependencies": [
{
"source": {
"local": {
"directory": "../../jl-common-lib/common-lib/common"
"git": {
"remote": "https://github.com/grafana/jsonnet-libs.git",
"subdir": "common-lib"
}
},
"version": ""
"version": "vzhuravlev/common-lib"
Copy link
Contributor

@rgeyer rgeyer Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this get merged first? Given it's a requirement, we should probably have that nailed down with some certainty that the interface will not change.

Copy link
Contributor Author

@v-zhuravlev v-zhuravlev Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commonlib is ready for review. once we merge it, we can continue with windows lib.

},
{
"source": {
Expand Down