Add option to scrape api-server via the kubernetes service, and not via the service endpoints. #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ia the service endpoints. We used the endpoints as on GKE you can't discover the pods (they don't run on your nodes), and we wanted to deal with the case where we might end up with multiple masters. This doesn't work on AKS. Signed-off-by: Tom Wilkie <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
gouthamve
approved these changes
Mar 21, 2019
jeschkies
pushed a commit
that referenced
this pull request
Dec 9, 2020
this has a minor change to the wording and a couple of examples to demonstrate the use of DATA_SOURCE_URI. Closes #113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used the endpoints as on GKE you can't discover the pods (they don't run on your nodes), and we wanted to deal with the case where we might end up with multiple masters.
This doesn't work on AKS.
Signed-off-by: Tom Wilkie [email protected]