Skip to content

feat: traefik alerts #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
v-zhuravlev merged 16 commits into from
Jul 2, 2025
Merged

feat: traefik alerts #1460

v-zhuravlev merged 16 commits into from
Jul 2, 2025

Conversation

@wbollock
Copy link
Contributor

@wbollock wbollock commented Jul 1, 2025

Adds two basic Traefik alerts. One for config reloads failing and the other for TLS certificate expiry.

@wbollock wbollock requested a review from a team as a code owner July 1, 2025 13:53
@CLAassistant
Copy link

CLAassistant commented Jul 1, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Dasomeone
Dasomeone reviewed Jul 1, 2025
View reviewed changes
Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @wbollock! Left one suggestion and ran the CI workflows, and it looks like there's a formatting issue with the alert file.

you can run make fmt which should take care of it

v-zhuravlev
v-zhuravlev reviewed Jul 1, 2025
View reviewed changes
v-zhuravlev
v-zhuravlev reviewed Jul 1, 2025
View reviewed changes
@wbollock wbollock requested review from Dasomeone and v-zhuravlev July 1, 2025 15:51
v-zhuravlev
v-zhuravlev reviewed Jul 2, 2025
View reviewed changes
@wbollock wbollock requested a review from v-zhuravlev July 2, 2025 13:47
v-zhuravlev
v-zhuravlev reviewed Jul 2, 2025
View reviewed changes
@v-zhuravlev
Copy link
Contributor

v-zhuravlev commented Jul 2, 2025

https://github.com/grafana/jsonnet-libs/actions/runs/16029355434/job/45226494129?pr=1460#step:7:8

@wbollock wbollock force-pushed the feat/traefik_alerts branch from 4bbcdcb to c3ebbc9 Compare July 2, 2025 15:51
@wbollock wbollock requested a review from v-zhuravlev July 2, 2025 15:55
@wbollock
Copy link
Contributor Author

wbollock commented Jul 2, 2025

grafana/jsonnet-libs/actions/runs/16029355434/job/45226494129?pr=1460#step:7:8

oh I see this too, looking [alert-description-templating] Alert TraefikConfigReloadFailuresIncreasing annotation 'description' must use templates, is currently 'Traefik is failing to reload its config'

v-zhuravlev
v-zhuravlev reviewed Jul 2, 2025
View reviewed changes
v-zhuravlev
v-zhuravlev reviewed Jul 2, 2025
View reviewed changes
v-zhuravlev
v-zhuravlev reviewed Jul 2, 2025
View reviewed changes
@wbollock @v-zhuravlev
ref: remove config comments
65f86e2 
Co-authored-by: v-zhuravlev <[email protected]>
@wbollock wbollock requested a review from v-zhuravlev July 2, 2025 16:52
@wbollock
Copy link
Contributor Author

wbollock commented Jul 2, 2025

weird... make diff but my local env matches the PR

@wbollock
Copy link
Contributor Author

wbollock commented Jul 2, 2025

whoops think it was some kind of yaml formatter in my IDE. fixed now!

@wbollock wbollock requested a review from v-zhuravlev July 2, 2025 18:11
@v-zhuravlev v-zhuravlev enabled auto-merge (squash) July 2, 2025 18:15
@v-zhuravlev v-zhuravlev merged commit 0818107 into grafana:master Jul 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dasomeone Dasomeone Awaiting requested review from Dasomeone

1 more reviewer

@v-zhuravlev v-zhuravlev v-zhuravlev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wbollock @CLAassistant @v-zhuravlev @Dasomeone