Only deploy Prometheus as statefulset, deploy replicas. #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
reviewed
Aug 17, 2019
tomwilkie
reviewed
Aug 17, 2019
Contributor
|
I'd make this only do that stateful change, and move the replicas logic here in the next PR. Small changes. |
of a single instance. Signed-off-by: Callum Styan <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
tomwilkie
force-pushed
the
prom-replicas
branch
from
2c58c7f to
300226b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the ability to deploy Prometheus as a deployment, it will always deploy Prom as a statefulset. Also adds Prometheus replicas/removes
main_prometheus.If we want I can make it so the statefulset/replicas are default but deployment/
main_prometheusare still available via config vars.Signed-off-by: Callum Styan [email protected]