upgrade apiVersion of deployment/daemonset/statefulset from v1beta1 to v1 for k8s v1.16+

[benjaminhuo]

Signed-off-by: Benjamin [email protected]

[tombrk]

According to https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/, the apps/v1 API is available since Kubernetes v1.9.

I think it is fair to assume that every user nowadays uses at least this version (otherwise they have probably bigger problems that these jsonnet-libs).

LGTM 🚀

[andrew-waters]

@benjaminhuo I'm pretty sure this has broken the memcache lib.

v1 statefulset requires a selector: if you don't add it (and you don't have it in the memcache code here), you'll get a validation error:

kubectl failed exit status 1: error validating data: ValidationError(StatefulSet.spec): missing required field "selector" in io.k8s.api.apps.v1.StatefulSetSpec

I've had a world of pain with Loki today that seems to root from this - and rolling back to $.apps.v1beta1.statefulSet fixes my deployment issues. I think the kube API is automatically adding it in v1beta1 but not in v1.

I may have missed something more obvious though

[tombrk]

Very good catch, apologies for having you to figure this out.

I reviewed based on the kubernetes migration doc and it didn't mention this, so I didn't think of this.

You are right, the v1 API requires an explicit selector. Opened an issue: #205

[andrew-waters]

No worries, thanks for the quick fix. I was wondering how to persist my vendor change 😂

[benjaminhuo]

@andrew-waters Sorry for overlooking this and thanks @sh0rez 's quick fix