Upgrade kubernetes-mixin #226
Conversation
| } | ||
| }, | ||
| "version": "release-0.1" | ||
| "version": "master" |
There was a problem hiding this comment.
nit: this sounds like a floating label that might change quite a lot -- is that ok?
There was a problem hiding this comment.
The point is not a nit. As @malcolmholmes also pointed out to me, we should not force a new version just because we upgraded. Fortunately, this is not much of a problem because of how jb (0.2.0 at least) works: it doesn't by default install/vendor dependencies of dependencies, because of this it is likely a conscious decision of downstream to vendor it in or not.
There was a problem hiding this comment.
As to justify the changes specific to our environment, the overrides and the version 'release-0.1' here were originally because we didn't upgrade. This PR should set things right.
There was a problem hiding this comment.
Yep, this was a locking back for Grafana Labs. This sets this right.
3 participants
We've updated most clusters to 1.14, should be safe to update kubernetes-mixin now.