Don't merge mixins in the global namespace anymore.

[tomwilkie]

Instead, put them in the $.mixins map.

This allows for mixins to be places in specific Grafana directories, and also removes the horrible bug around playbook links.

Still support merging into the global namespace for the time being, but this will be going away.

NB this also removes the old field names (grafana_dashboards), I couldn't find a mixin that used this anymore.

Signed-off-by: Tom Wilkie [email protected]

[tombrk]

Looks good! You could add some comments to the foldr functions explaining what's their purpose.

Also I'd like to wait @malcolmholmes review, as he's currently rewriting parts of this lib as well, just to make sure these don't interfere

[malcolmholmes]

But the $.mixins map is still global.

You could say, the current approach is that prometheus-ksonnet "reaches out" into the global namespace for its mixins. What I am attempting to move us towards is where we create a Grafana or a "monitoring thing" and pass it our mixins:

local mymixin = import 'mymixin.libsonnet';
local grafana = import 'grafana.libsonnet';
{
  grafana: grafana.new()
     + grafana.withMixin(mymixin),
}

Which is a more conventional programming model. Because the grafana object (or monitoring thingie) holds the mixins within it, we can now have as many as we like, without them overlapping, because they have their resources handed to them, rather than the 'reaching out' that we are currently doing.

[tomwilkie]

@malcolmholmes said

I don't see this as a need to block that PR