Copy some dashboard opinions from kubernete-mixin and apply to all dashboards. #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shboards. Previously, this would happen automatically as all mixins were merged into one. Now we keep mixins in different namespaces, this needs to be done by out grafana jsonnet code. Opinions are: // - Dashboard UIDs should be the md5 hash of their filename. // - Timezone should be default (ie local). // - Tooltip should only show a single value. Signed-off-by: Tom Wilkie <[email protected]>
tomwilkie
force-pushed
the
dashboard-opinions
branch
from
48d9a2f to
0626512
Compare
tombrk
approved these changes
Apr 8, 2020
| local mixinProto = { | ||
| grafanaDashboards+:: {}, | ||
| } + { | ||
| local grafanaDashboards = super.grafanaDashboards, |
Member
There was a problem hiding this comment.
just to clarify, super here is the already merged $.mixins[mixinName] + { grafanaDashboards+:: {} }?
Contributor
Author
There was a problem hiding this comment.
Yes, thats just there so we can reliably reference super.grafanaDashboards (you can do std.hasField(super, ...).
Comment on lines
18
to
20
| // - Dashboard UIDs should be the md5 hash of their filename. | ||
| // - Timezone should be "default" (ie local). | ||
| // - Tooltip should only show a single value. |
Member
There was a problem hiding this comment.
should sounds like we do validation here – but we actually just force this behaviour
Signed-off-by: Tom Wilkie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this would happen automatically as all mixins were merged into one. Now we keep mixins in different namespaces, this needs to be done by out grafana jsonnet code.
Opinions are:
// - Dashboard UIDs should be the md5 hash of their filename.
// - Timezone should be default (ie local).
// - Tooltip should only show a single value.
Signed-off-by: Tom Wilkie [email protected]