support for generating slack receivers with buttons for alerts #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandeep Sukhani <[email protected]>
tomwilkie
requested review from
Duologic,
malcolmholmes,
tombrk and
trotttrotttrott
tomwilkie
reviewed
Apr 20, 2020
tomwilkie
reviewed
Apr 20, 2020
tombrk
approved these changes
Apr 20, 2020
Member
tombrk
left a comment
tombrk
left a comment
There was a problem hiding this comment.
This is cool! With the comments from @tomwilkie addressed, LGTM 🚀
beorn7
approved these changes
Apr 20, 2020
Contributor
beorn7
left a comment
beorn7
left a comment
There was a problem hiding this comment.
Modulo @tomwilkie 's note.
…e of silence button template Signed-off-by: Sandeep Sukhani <[email protected]>
malcolmholmes
approved these changes
Apr 21, 2020
tomwilkie
reviewed
Apr 21, 2020
tomwilkie
reviewed
Apr 21, 2020
Duologic
approved these changes
Apr 21, 2020
Contributor
Author
|
@tomwilkie I have addressed all the feedbacks. Do you want to do another pass or this is good to merge now? |
Contributor
|
That looks really good, thanks for sticking with this Sandeep. LGTM! |
tomwilkie
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sandeep Sukhani [email protected]