Skip to content

prometheus-ksonnet README fixes #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robx merged 2 commits into from
Jun 23, 2020
Merged

prometheus-ksonnet README fixes #267

robx merged 2 commits into from
Jun 23, 2020

Conversation

@robx
Copy link
Contributor

@robx robx commented Jun 2, 2020 •
edited
Loading

  • Without jsonnet-bundler installed, the tk init step fails trying
    to install k.libsonnet.
  • The way to get the current context seems to use the kubectl config command.

robx added 2 commits June 2, 2020 09:21
@robx
Require jsonnet-bundler earlier, to fix tk init.
5d9c558 
Without jsonnet-bundler installed, the `tk init` step fails trying
to install k.libsonnet.
@robx
Fix kubectl current-context command.
a5d9d63
@robx robx changed the title prometheus-ksonnet README: Require jsonnet-bundler earlier, to fix tk init. prometheus-ksonnet README fixes Jun 2, 2020
@robx robx requested a review from tombrk June 23, 2020 07:28
tombrk
tombrk approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@tombrk tombrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, these are all correct 🚀

@robx robx merged commit f883d05 into grafana:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tombrk tombrk tombrk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robx @tombrk