A Promsonnet library for creating Prometheus Rules #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcolmholmes
requested review from
Duologic,
beorn7,
sdboyer and
trotttrotttrott
beorn7
requested changes
Oct 14, 2020
beorn7
approved these changes
Oct 15, 2020
Contributor
beorn7
left a comment
beorn7
left a comment
There was a problem hiding this comment.
Looks good from my side. Jsonnet and general config language experts might still have something to say about this.
Duologic
approved these changes
Oct 19, 2020
promsonnet/README.md
Outdated
Comment on lines
6
to
7
| recording rules after the fact. (With lists, this requires iteration, and | ||
| is complex. |
Contributor
There was a problem hiding this comment.
Suggested change
| recording rules after the fact. (With lists, this requires iteration, and | |
| is complex. | |
| recording rules after the fact, in contrast, lists require complex iteration logic. |
malcolmholmes
force-pushed
the
add-promsonnet-lib
branch
from
371b51c to
1e35b55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple library for rendering Prometheus rules. Provides a workaround for the issue that patching Prometheus alerts/recording rules is hard in Jsonnet, as individual elements in a list are not addressable. Under the bonnet, this stores rules in a map, then renders the required list late. The entries in the map can be patched, as demonstrated in the example
patch.jsonnet.Comments/thoughts/approvals welcome.