-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix: update loki-helm-test image tag to latest commit #19227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JStickler
merged 8 commits into
grafana:main
from
puretension:fix-helm-test-image-update-19162
Sep 23, 2025
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b11b240
fix: update loki-helm-test image tag to latest commit
puretension d9efd12
fix: use Chart.AppVersion for loki-helm-test image tag
puretension 9201796
Merge branch 'main' into fix-helm-test-image-update-19162
puretension 7752824
docs: update helm chart reference documentation
puretension 49a8690
Merge branch 'main' into fix-helm-test-image-update-19162
JStickler d445e5c
fix: use latest tag for loki-helm-test image
puretension 6fdd00d
Merge branch 'main' into fix-helm-test-image-update-19162
JStickler 3f632fa
docs: update helm chart reference for loki-helm-test latest tag
puretension File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
fix: update loki-helm-test image tag to latest commit
Fixes #19162 Signed-off-by: puretension <[email protected]>
- Loading branch information
commit b11b24052c7a01f79efc2290df847e38ca558b47
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think maybe this should just be set to match the same version used for the loki image and enterprise logs image?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're absolutely right! I've updated the implementation to use .Chart.AppVersion instead of a hardcoded commit hash.
This ensures the loki-helm-test image automatically matches the main loki image version.
Thank you for thefeedback!