Skip to content

fix(helm): support global registry override for sidecar #19671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Scrumplex wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(helm): support global registry override for sidecar #19671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(helm): support global registry override for sidecar 
Since #19246 the sidecar image would
resolve to registry-mirror.example.com/docker.io/kiwigrid/k8s-sidecar
when a global registry mirror was defined.

Signed-off-by: Sefa Eyeoglu <[email protected]>
  • Loading branch information
@Scrumplex
Scrumplex committed Nov 4, 2025
commit 9e9ebeaaf02167ca8cae9c277f8fc08678e2ec13
13 changes: 11 additions & 2 deletions docs/sources/setup/install/helm/reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12269,14 +12269,23 @@ false
<td><pre lang="json">
"IfNotPresent"
</pre>
</td>
</tr>
<tr>
<td>sidecar.image.registry</td>
<td>string</td>
<td>The Docker registry for the k8s sidecar</td>
<td><pre lang="json">
"docker.io"
</pre>
</td>
</tr>
<tr>
<td>sidecar.image.repository</td>
<td>string</td>
<td>The Docker registry and image for the k8s sidecar</td>
<td>Docker image repository for the k8s sidecar</td>
<td><pre lang="json">
"docker.io/kiwigrid/k8s-sidecar"
"kiwigrid/k8s-sidecar"
</pre>
</td>
</tr>
Expand Down
1 change: 1 addition & 0 deletions production/helm/loki/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Entries should include a reference to the pull request that introduced the chang
- [BUGFIX] Wrong context passed to loki.namespace helper from table manager servicemonitor. [#19461](https://github.com/grafana/loki/pull/19461)
- [BUGFIX] Don't fail for missing bucket name, if local disk is used. [#19675](https://github.com/grafana/loki/pull/19675)
- [FEATURE] Add load balancer port to query-frontend service. [#19462](https://github.com/grafana/loki/pull/19462)
- [BUGFIX] Support global registry override for sidecar. [#19671](https://github.com/grafana/loki/pull/19671)

## 6.45.2

Expand Down
6 changes: 4 additions & 2 deletions production/helm/loki/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3997,8 +3997,10 @@ extraObjects: null

sidecar:
image:
# -- The Docker registry and image for the k8s sidecar
repository: docker.io/kiwigrid/k8s-sidecar
# -- The Docker registry for the k8s sidecar
registry: docker.io
# -- Docker image repository for the k8s sidecar
repository: kiwigrid/k8s-sidecar
# -- Docker image tag
tag: 1.30.10
# -- Docker image sha. If empty, no sha will be used
Expand Down
Loading