mixin: Accept suffixes to pod name in instance labels #2080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the instance label is just the pod name, but that's insufficient, cf. grafana/deployment_tools#3441 . In the near future, we'll suffix the pod name in the instance label with container name and/or port name. To make this mixin still work, adjust the `instance` label matcher. Signed-off-by: beorn7 <[email protected]>
Contributor
Author
|
@joe-elliott gentle ping. |
joe-elliott
approved these changes
May 18, 2020
Contributor
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
Apologies. Missed this one.
LGTM!
Contributor
Author
|
I'll update the vendoring on this one together with grafana/jsonnet-libs#261. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the instance label is just the pod name, but that's
insufficient,
cf. https://github.com/grafana/deployment_tools/issues/3441 .
In the near future, we'll suffix the pod name in the instance label
with container name and/or port name. To make this mixin still work,
adjust the
instancelabel matcher.