Add Macos observability lib #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
show networkErrorsAndDroppedPerSec instead of networkErrorPerSec for Linux/MacOS
To allow to locally import linux from macos
Dasomeone
reviewed
Nov 21, 2023
Member
Dasomeone
left a comment
Dasomeone
left a comment
There was a problem hiding this comment.
Small comment re: networking panels, but generally looks great!
Comment on lines
61
to
+62
| panels.networkUsagePerSec { gridPos+: { w: 12, h: 8 } }, | ||
| panels.networkErrorsPerSec { gridPos+: { w: 12, h: 8 } }, | ||
| panels.networkErrorsAndDroppedPerSec { gridPos+: { w: 12, h: 8 } }, |
Member
There was a problem hiding this comment.
Oh maybe it is something we could discuss here then, I'm not a fan of how busy the network panels are as seen in the screenshot in the description. In particular the body is v. busy. At the very least I'd recommend dropping any metrics with 0/null values to clean up the legend.
Maybe right-aligning with a table as well, to stay consistent with our own style guide?
…ring selected dashboard interval
Dasomeone
approved these changes
Nov 28, 2023
Member
Dasomeone
left a comment
Dasomeone
left a comment
There was a problem hiding this comment.
Awesome, thank you for addressing the network panel feedback :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add macos-observ-lib: