fix: remove named returns [N-08]

contracts/l2/reservoir/L2Reservoir.sol

@@ -55,22 +55,23 @@ contract L2Reservoir is L2ReservoirV1Storage, Reservoir, IL2Reservoir {
      * - t0 is the last drip block, i.e. lastRewardsUpdateBlock
      * - r is the issuanceRate
      * @param _blocknum Block number at which to calculate rewards
-     * @return deltaRewards New total rewards on L2 since the last drip
+     * @return New total rewards on L2 since the last drip
      */
     function getNewRewards(uint256 _blocknum)
         public
         view
         override(Reservoir, IReservoir)
-        returns (uint256 deltaRewards)
+        returns (uint256)
     {
         uint256 t0 = lastRewardsUpdateBlock;
         if (issuanceRate <= MIN_ISSUANCE_RATE || _blocknum == t0) {
             return 0;
         }
-        deltaRewards = issuanceBase
-            .mul(_pow(issuanceRate, _blocknum.sub(t0), TOKEN_DECIMALS))
-            .div(TOKEN_DECIMALS)
-            .sub(issuanceBase);
+        return
+            issuanceBase
+                .mul(_pow(issuanceRate, _blocknum.sub(t0), TOKEN_DECIMALS))
+                .div(TOKEN_DECIMALS)
+                .sub(issuanceBase);
     }
 
     /**

contracts/reservoir/IReservoir.sol

@@ -20,16 +20,16 @@ interface IReservoir {
     /**
      * @dev Get accumulated total rewards on this layer at a particular block
      * @param _blocknum Block number at which to calculate rewards
-     * @return totalRewards Accumulated total rewards on this layer
+     * @return Accumulated total rewards on this layer
      */
-    function getAccumulatedRewards(uint256 _blocknum) external view returns (uint256 totalRewards);
+    function getAccumulatedRewards(uint256 _blocknum) external view returns (uint256);
 
     /**
      * @dev Get new total rewards on this layer at a particular block, since the last drip event
      * @param _blocknum Block number at which to calculate rewards
-     * @return deltaRewards New total rewards on this layer since the last drip
+     * @return New total rewards on this layer since the last drip
      */
-    function getNewRewards(uint256 _blocknum) external view returns (uint256 deltaRewards);
+    function getNewRewards(uint256 _blocknum) external view returns (uint256);
 }
 
 /**

contracts/reservoir/L1Reservoir.sol

@@ -234,17 +234,18 @@ contract L1Reservoir is L1ReservoirV1Storage, Reservoir {
      * - t0 is the last drip block, i.e. lastRewardsUpdateBlock
      * - r is the issuanceRate
      * @param _blocknum Block number at which to calculate rewards
-     * @return deltaRewards New total rewards on both layers since the last drip
+     * @return New total rewards on both layers since the last drip
      */
-    function getNewGlobalRewards(uint256 _blocknum) public view returns (uint256 deltaRewards) {
+    function getNewGlobalRewards(uint256 _blocknum) public view returns (uint256) {
         uint256 t0 = lastRewardsUpdateBlock;
         if (issuanceRate <= MIN_ISSUANCE_RATE || _blocknum == t0) {
             return 0;
         }
-        deltaRewards = issuanceBase
-            .mul(_pow(issuanceRate, _blocknum.sub(t0), TOKEN_DECIMALS))
-            .div(TOKEN_DECIMALS)
-            .sub(issuanceBase);
+        return
+            issuanceBase
+                .mul(_pow(issuanceRate, _blocknum.sub(t0), TOKEN_DECIMALS))
+                .div(TOKEN_DECIMALS)
+                .sub(issuanceBase);
     }
 
     /**
@@ -253,12 +254,13 @@ contract L1Reservoir is L1ReservoirV1Storage, Reservoir {
      * - deltaR is the new global rewards on both layers (see getNewGlobalRewards)
      * - lambda is the fraction of rewards sent to L2, i.e. l2RewardsFraction
      * @param _blocknum Block number at which to calculate rewards
-     * @return deltaRewards New total rewards on Layer 1 since the last drip
+     * @return New total rewards on Layer 1 since the last drip
      */
-    function getNewRewards(uint256 _blocknum) public view override returns (uint256 deltaRewards) {
-        deltaRewards = getNewGlobalRewards(_blocknum)
-            .mul(TOKEN_DECIMALS.sub(l2RewardsFraction))
-            .div(TOKEN_DECIMALS);
+    function getNewRewards(uint256 _blocknum) public view override returns (uint256) {
+        return
+            getNewGlobalRewards(_blocknum).mul(TOKEN_DECIMALS.sub(l2RewardsFraction)).div(
+                TOKEN_DECIMALS
+            );
     }
 
     /**

contracts/reservoir/Reservoir.sol

@@ -33,44 +33,35 @@ abstract contract Reservoir is GraphUpgradeable, ReservoirV1Storage, IReservoir
     /**
      * @dev Get accumulated total rewards on this layer at a particular block
      * @param _blocknum Block number at which to calculate rewards
-     * @return totalRewards Accumulated total rewards on this layer
+     * @return Accumulated total rewards on this layer
      */
-    function getAccumulatedRewards(uint256 _blocknum)
-        public
-        view
-        override
-        returns (uint256 totalRewards)
-    {
+    function getAccumulatedRewards(uint256 _blocknum) public view override returns (uint256) {
         // R(t) = R(t0) + (DeltaR(t, t0))
-        totalRewards = accumulatedLayerRewards + getNewRewards(_blocknum);
+        return accumulatedLayerRewards + getNewRewards(_blocknum);
     }
 
     /**
      * @dev Get new total rewards on this layer at a particular block, since the last drip event.
      * Must be implemented by the reservoir on each layer.
      * @param _blocknum Block number at which to calculate rewards
-     * @return deltaRewards New total rewards on this layer since the last drip
+     * @return New total rewards on this layer since the last drip
      */
-    function getNewRewards(uint256 _blocknum)
-        public
-        view
-        virtual
-        override
-        returns (uint256 deltaRewards);
+    function getNewRewards(uint256 _blocknum) public view virtual override returns (uint256);
 
     /**
      * @dev Raises _x to the power of _n with scaling factor of _base.
      * Based on: https://github.com/makerdao/dss/blob/master/src/pot.sol#L81
      * @param _x Base of the exponentiation
      * @param _n Exponent
      * @param _base Scaling factor
-     * @return z Exponential of _n with base _x
+     * @return Exponential of _n with base _x
      */
     function _pow(
         uint256 _x,
         uint256 _n,
         uint256 _base
-    ) internal pure returns (uint256 z) {
+    ) internal pure returns (uint256) {
+        uint256 z;
         // solhint-disable-next-line no-inline-assembly
         assembly {
             switch _x
@@ -120,5 +111,6 @@ abstract contract Reservoir is GraphUpgradeable, ReservoirV1Storage, IReservoir
                 }
             }
         }
+        return z;
     }
 }