Skip to content

Short circuit value cache look up to avoid object allocations #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Short circuit value cache look up to avoid object allocations #109

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b01def5
This introduces a special exception that can be used to short circuit…
bbakerman Feb 14, 2022
66f1dbe
Removed synchronised
bbakerman Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Removed synchronised
  • Loading branch information
@bbakerman
bbakerman committed Feb 14, 2022
commit 66f1dbe44f30c577835f2c610555ab94df11da11
2 changes: 1 addition & 1 deletion src/main/java/org/dataloader/ValueCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ default CompletableFuture<List<V>> setValues(List<K> keys, List<V> values) throw
*/
class ValueCachingNotSupported extends UnsupportedOperationException {
@Override
public synchronized Throwable fillInStackTrace() {
public Throwable fillInStackTrace() {
return this;
}
Copy link
Member Author

@bbakerman bbakerman Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is magic - the exception has no stack trace (we don't want one) AND its fast to allocate because of this.

Copy link

@jord1e jord1e Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need it to be synchronized?

Copy link
Member Author

@bbakerman bbakerman Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - it is in the base class. I will change this

}
Expand Down