Skip to content

ValueCache calls are made inside the batch load call #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 9, 2021
Merged

ValueCache calls are made inside the batch load call #99

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e3e70a4
This adds support for calling dispatch if the ValueCache takes time i…
bbakerman Jul 31, 2021
ae0a29e
javadoc problem
bbakerman Jul 31, 2021
a74031a
This attacks the problem os async ValueCache lookups in the batch loa…
bbakerman Aug 7, 2021
38b3755
Doco updated and removed get returning Try
bbakerman Aug 8, 2021
d8078e0
more tests and more resilient setCache calls
bbakerman Aug 8, 2021
d691f88
found a buf where the cache set is done on entries that are already i…
bbakerman Aug 8, 2021
efdb9a7
improved the set cache code - thenCompose was missing
bbakerman Aug 8, 2021
4ecb786
Moved to CompletableFuture inside code
bbakerman Aug 9, 2021
af28c04
better asserts
bbakerman Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
javadoc problem
  • Loading branch information
@bbakerman
bbakerman committed Jul 31, 2021
commit ae0a29e85c4458e277110d169d1066d68d4364ba
2 changes: 1 addition & 1 deletion src/main/java/org/dataloader/ValueCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* <p>
* It differs from {@link CacheMap} which is in fact a cache of promised values aka {@link CompletableFuture}&lt;V&gt;'s.
* <p>
* {@link ValueCache is more suited to be a wrapper of a long-lived or externallly cached values. {@link CompletableFuture}s cant
* {@link ValueCache} is more suited to be a wrapper of a long-lived or externallly cached values. {@link CompletableFuture}s cant
* be easily placed in an external cache outside the JVM say, hence the need for the {@link ValueCache}.
* <p>
* {@link DataLoader}s use a two stage cache strategy if caching is enabled. If the {@link CacheMap} already has the promise to a value
Expand Down