Skip to content

Simplify props.py #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simplify props.py #1511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Simplify props.py 
It had code for handling the differences between old-style and new-style classes in Python 2, but support for Python 2 was dropped long ago.
  • Loading branch information
@RJPercival
RJPercival authored Jul 4, 2023
commit 6d609db8c052d30ecf7386228d0c8c81167a4324
10 changes: 3 additions & 7 deletions graphene/utils/props.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
class _OldClass:
class _Class:
pass


class _NewClass:
pass


_all_vars = set(dir(_OldClass) + dir(_NewClass))
_built_in_vars = set(dir(_Class))


def props(x):
return {
key: vars(x).get(key, getattr(x, key)) for key in dir(x) if key not in _all_vars
key: vars(x).get(key, getattr(x, key)) for key in dir(x) if key not in _built_in_vars
}