Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: graphql/graphql-js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3c0ba0b
Choose a base ref
...
head repository: graphql/graphql-js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4171fc6
Choose a head ref
  • 16 commits
  • 70 files changed
  • 4 contributors

Commits on May 6, 2021

  1. Configuration menu
    Copy the full SHA
    83751a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    960f207 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2021

  1. Configuration menu
    Copy the full SHA
    5579180 View commit details
    Browse the repository at this point in the history
  2. Refine parse and AST to represent ConstValue (#3059)

    This adds:
    
    * ConstValueNode - A subtype of ValueNode which recursively excludes Variables
    * Improved syntax error when encountering variable in a const value
    * parseConstValue(): ConstValueNode
    * isConstValue(): ConstValueNode
    * Various refinements to AST types to use ConstValueNode (or a type which includes it) to better align to the spec.
    leebyron authored May 8, 2021
    Configuration menu
    Copy the full SHA
    513eacc View commit details
    Browse the repository at this point in the history

Commits on May 10, 2021

  1. Configuration menu
    Copy the full SHA
    1af561f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d695f53 View commit details
    Browse the repository at this point in the history
  3. Flow: add missing names to arguments of function types (#3072)

    In preparation to TS convertion
    IvanGoncharov authored May 10, 2021
    Configuration menu
    Copy the full SHA
    bd5583c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3cfb2be View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    78d5f83 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    98dcac3 View commit details
    Browse the repository at this point in the history
  7. Unify InputValueConfig in schema definition

    Defines a central `GraphQLInputValueConfig` and `GraphQLInputValue` as well as single definitions for converting between them, unifying this common functionality between input values and arguments.
    
    This is a pre-req for #3049
    leebyron committed May 10, 2021
    Configuration menu
    Copy the full SHA
    13c3957 View commit details
    Browse the repository at this point in the history
  8. Also add isRequiredInput()

    leebyron committed May 10, 2021
    Configuration menu
    Copy the full SHA
    13ef6fe View commit details
    Browse the repository at this point in the history
  9. Revert DirectiveArgument

    leebyron committed May 10, 2021
    Configuration menu
    Copy the full SHA
    5d0c2f3 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1d87c02 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. Preserve defaultValue literals

    Fixes #3051
    leebyron committed May 11, 2021
    Configuration menu
    Copy the full SHA
    0a91e63 View commit details
    Browse the repository at this point in the history
  2. Add valueToLiteral() and literalToValue()

    * Adds `valueToLiteral()` which takes an external value and translates it to a literal, allowing for custom scalars to define this behavior.
    * Adds `literalToValue()` which does the same in reverse, also allowing custom scalars to define it.
    * Deprecates `valueFromASTUntyped()` in favor of `literalToValue()`, replacing all use of it in the codebase and adding a printed warning (via a new `deprecationWarning` method).
    
    This also adds important changes to Input Coercion, especially for custom scalars:
    
    * The value provided to `parseLiteral` is now `ConstValueNode` and the second `variables` argument has been removed. For all built-in scalars this has no effect, but any custom scalars which use complex literals no longer need to do variable reconciliation manually (in fact most do not -- this has been an easy subtle bug to miss).
    
      This behavior is possible with the addition of `replaceASTVariables`
    * The `parseLiteral` function is no longer filled with a default implementation. Callsites need to check for it before calling it. This untangles what would otherwise be a circular dependency. Both callsites are updated.
    leebyron committed May 11, 2021
    Configuration menu
    Copy the full SHA
    4171fc6 View commit details
    Browse the repository at this point in the history
Loading