Skip to content

Conversation

acao
Copy link
Member

@acao acao commented Jul 21, 2023

Closes #1427

Description

restore 200 reverse proxy rewrite logic for swapi-graphql

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 21, 2023

✅ graphql.github.io-source deploy preview ready

@acao acao force-pushed the swapi-rewrite-rule branch from fd2c946 to 5c6d26f Compare July 21, 2023 12:26
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note to self: though this says createRedirect what's actually happening is that Gatsby is creating a reverse proxy (hence the statusCode: 200) - odd choice of name for that API but 🤷

@benjie
Copy link
Member

benjie commented Jul 21, 2023

Should also fix graphql/swapi-graphql#219

@benjie benjie changed the title restore swapi 200 rewrite Restore /swapi-graphql endpoint via reverse proxy Jul 21, 2023
@benjie benjie merged commit b52ece7 into graphql:source Jul 21, 2023
@benjie
Copy link
Member

benjie commented Jul 21, 2023

It worked on the preview so I've merged it 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting 404 on /swapi-graphql

2 participants