Skip to content

Conversation

francisfuzz
Copy link

Hi there @leebyron 👋

I'm pinging you because the changes proposed here modify a line in site/_css/index.less, which was last worked on in 79e3bb1 as a part of the work done in #76.

If you're not maintaining this part of the code anymore, please let me know if there's a better person I should get in touch with about this change. Thanks! 🙇

Context

Let's say I navigate to http://graphql.org, where my window has width of less than 1020px.

Here's how the Evolve your API without versions section looks like when viewed from a window whose width is less than 1020px:

broken-diff

This pull request modifies site/_css/index.less to use the padding-right attribute instead of the right attribute so it doesn't look like that anymore:

proposed-changes

@leebyron
Copy link
Collaborator

leebyron commented Feb 7, 2017

Thanks for your investigation into this! This change seems like patching a symptom rather than fixing the root issue though. Typically percentage based paddings can cause skew in the actual pixel where elements end up.

@leebyron leebyron closed this in 1d02f1e Feb 7, 2017
@leebyron
Copy link
Collaborator

leebyron commented Feb 7, 2017

The root issue seemed to be an over-application of text-align: center which makes sense since the broken screenshot shows the + centered in the line.

Dipeshwagle pushed a commit to Dipeshwagle/graphql.github.io that referenced this pull request Aug 18, 2020
When <1020px, text-align center was too broadly applied, causing other aspects of the UI to be misaligned.

Fixes graphql#231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants