Fix up React warnings and invalid markup #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't know what I was smoking when I removed this. Even though the function doesn't use it, React uses the key. This reverts commit 937b0d3.
Discovered because I was looking for React unique key warnings during the build and found that this file was responsible for one of them.
Build was printing: Warning: validateDOMNesting(...): <a> cannot appear as a descendant of <a>. See Marked > a > ... > a. Caused by markup like: [https://example.com/](https://example.com) Just rely on autolinking instead.
Dipeshwagle
pushed a commit
to Dipeshwagle/graphql.github.io
that referenced
this pull request
Aug 18, 2020
Fix up React warnings and invalid markup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.