Update Learn-Schema.md -- Improve Union Type Examples #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `__typename` to the query to show that union types can still be differentiated on the client and add a second example showing common fields being queried in one spot.
stubailo
reviewed
Jan 1, 2019
| # { "graphiql": true} | ||
| { | ||
| search(text: "an") { | ||
| __typename |
There was a problem hiding this comment.
Can we add something to the text regarding this?
There was a problem hiding this comment.
@stubailo That should be all set now.
|
Thanks! |
Dipeshwagle
pushed a commit
to Dipeshwagle/graphql.github.io
that referenced
this pull request
Aug 18, 2020
* Update Learn-Schema.md Add `__typename` to the query to show that union types can still be differentiated on the client and add a second example showing common fields being queried in one spot. * Add note about the use of `__typename`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
__typenameto the query to show that union types can still be differentiated on the client and adds a second example showing common fields being queried in one spot.There is another way to accomplish the same thing that I pointed out in this PR using fragments. Ultimately I felt like the solution targeting the common interface was cleaner and adding a note about Fragments might feel cluttered, but we can add this example if desired as well:
{ search(text: "an") { __typename ... on Human { ...CharacterProps height } ... on Droid { ...CharacterProps primaryFunction } ... on Starship { name length } } } fragment CharacterProps on Character { name }