Bench: storybook-5730da9-0

[everettbu]

Recreation of PR: N/A

Benchmark PR storybook-5730da9-0.

• Source repo: https://github.com/storybookjs/storybook
• Instigator commit: 5730da97769dc2c37c55c07f0bdbb5657f388e7b
• Base commit: da0e6f435bca90680e909c14f77a6dd7a02abdeb
• Bug fixed in PR: Addon Vitest: Support init in Vitest >= 3.2 storybookjs/storybook#31715

[greptile-apps]

Greptile Overview

Greptile Summary

This PR implements a performance optimization for Storybook's Vite builder by refactoring dependency optimization configuration. The main change extracts a large constant array (INCLUDE_CANDIDATES) containing 143 dependency names from the optimizeDeps logic into a dedicated constants file. This constant defines packages that need pre-optimization by Vite to convert from CommonJS to ESM format, preventing startup delays. The refactoring improves code organization by separating configuration data from business logic, making the optimizeDeps module more focused and maintainable. Additionally, the Vitest plugin is updated to leverage these same optimization candidates, ensuring consistent dependency handling across both build and test environments.

Important Files Changed

Filename	Score	Overview
code/builders/builder-vite/src/constants.ts	5/5	New file containing 143 dependency candidates for Vite optimization with clear documentation
code/builders/builder-vite/src/optimizeDeps.ts	5/5	Refactored to import INCLUDE_CANDIDATES from constants file, maintaining identical functionality
code/addons/vitest/src/vitest-plugin/index.ts	4/5	Enhanced to include Vite optimization candidates for improved test performance

Confidence score: 5/5

• This PR is safe to merge with minimal risk as it primarily involves code organization and performance optimization
• Score reflects clean refactoring with no functional changes to core logic, proper import structure, and consistent application across related modules
• No files require special attention as the changes are straightforward constant extraction and consistent usage patterns

Sequence Diagram

sequenceDiagram
    participant User
    participant VitestPlugin as "Vitest Plugin"
    participant StorybookLoader as "Storybook Loader"
    participant ViteConfig as "Vite Config"
    participant OptimizeDeps as "Optimize Deps"
    participant Constants as "Constants"

    User->>VitestPlugin: "Initialize storybookTest plugin"
    VitestPlugin->>StorybookLoader: "experimental_loadStorybook(configDir)"
    StorybookLoader-->>VitestPlugin: "Return presets"
    
    VitestPlugin->>VitestPlugin: "Apply presets for stories, framework, env, etc."
    
    VitestPlugin->>Constants: "Import INCLUDE_CANDIDATES"
    Constants-->>VitestPlugin: "Return predefined dependencies list"
    
    VitestPlugin->>VitestPlugin: "Configure optimizeDeps with INCLUDE_CANDIDATES"
    
    VitestPlugin->>ViteConfig: "Return plugin configuration"
    ViteConfig->>OptimizeDeps: "getOptimizeDeps(config, options)"
    
    OptimizeDeps->>Constants: "Use INCLUDE_CANDIDATES"
    Constants-->>OptimizeDeps: "Return dependency candidates"
    
    OptimizeDeps->>OptimizeDeps: "Filter and resolve dependencies"
    OptimizeDeps-->>ViteConfig: "Return optimized dependencies config"
    
    ViteConfig-->>User: "Plugin configuration complete"

Loading

[greptile-apps]

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}