-
Notifications
You must be signed in to change notification settings - Fork 47
[MINOR] Handle multiple responses are returned from MCP #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@grll can you please take a look at this? 🙏 |
Hey thanks a lot for the contribution. Sorry for the delay I will try to review ASAP |
grll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we go for the backward compatible change then, this would mean we can revert the test and just add a new test to check that multiple value get a string representation of the list with all the values.
Also if you feel like it you could add a warning similar to smolagents adapter about the the fact that we only support text.
grll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good thank you for making the change. I would just remove the single content test as I think it is anyway already tested above that case. Then we should be good to merge. Thanks again!
|
@navinpai thank you for the change! Merged and released in v0.1.15 |
When MCP server returns multiple returns (especially in
streamable-httpMCP servers),mcpadaptCrewAIAdaperonly returns the first response. This minor PR collates all the responses text into a list and returns the entire response to CrewAI so it can use the entire response.Tested with
crewai==0.165.1Note: This issue was also reported in #55