bk(): Remove the separators between the units of time #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR #60 we discussed the use of the local timezone instead of UTC. While doing so we figured out that the current implementation is broken on VFAT. This solution removes the delimiters between the units of time which is fully IS0 8601 compliant and should work well on all filesystems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #60 we discussed the use of the local timezone instead of UTC. While doing
so we figured out that the current implementation is broken on VFAT.
This solution removes the delimiters between the units of time which is fully
IS0 8601 compliant and should work well on all filesystems.
@moviuro: I did not want to interfere with your PR, so I would be pleased if you can give me any feedback to this change. (Using the local time vs UTC should be discussed in your PR, but removing the separators is needed anyway).
/cc @mika, @btittelbach