protoc-gen-openapiv2: Assign user-defined service name as method tag #5339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
requested changes
Mar 12, 2025
Collaborator
johanbrandhorst
left a comment
johanbrandhorst
left a comment
There was a problem hiding this comment.
Thanks for this! Looks like the integration tests will need fixing.
Contributor
Author
|
Thank you for the warning! Fixed the tests and successfully ran them locally. |
rohitlohar45
pushed a commit
to rohitlohar45/grpc-gateway
that referenced
this pull request
Mar 13, 2025
…rpc-ecosystem#5339) * protoc-gen-openapiv2: Assign user-defined service name as method tag * Update BUILD.bazel * fix(protoc-gen-openapiv2): correct API client method reference in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
Fixes #3829
Have you read the Contributing Guidelines?
Yes
Brief description of what is fixed or changed
This PR builds on #3830 to ensure the correct method tag is applied in all scenarios when the user explicitly defines the service name.
Other comments
N/a