fix(lint,gosec): explicitly ignore errors from discarded HTTP request… #5645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… body
Without this change, if the generated code uses Gosec, it may flag with
a message similar to:
```
G104 (CWE-703): Errors unhandled (Confidence: HIGH, Severity: LOW)
77: )
> 78: io.Copy(io.Discard, req.Body)
79: if err := req.ParseForm(); err != nil {
```
huin
force-pushed
the
explicitly-ignore-discard-error
branch
from
2c7e1aa to
711f975
Compare
Contributor
Author
|
Updated with requested fix. |
Contributor
Author
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… body
Without this change, if the generated code uses Gosec, it may flag with a message similar to:
Have you read the Contributing Guidelines?
Yes. I have regenerated some files following the instructions.
I did have to inject
export GOFLAGS=-buildvcs=false &&into the bash command run in the first Docker command to avoid an error.Brief description of what is fixed or changed
When Gosec is used, the generated code generated a warning G104 due to the implicitly ignored error from
io.Copy. This seems relatively harmless (aside from potentially ignoring errors from reading the request body), so making the ignore explicit to placate the security checker.Other comments