Skip to content

api: Deprecate the old way of handling resolved addresses in LB #10028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
temawi wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

api: Deprecate the old way of handling resolved addresses in LB #10028

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d122d3a
api: Deprecate the old way of handling resolved addresses in LoadBala…
temawi Apr 7, 2023
8d1b132
Forwarding and GracefulSwitch LBS to ignore deprecation
temawi Apr 10, 2023
4b51da5
Ignore deprectaion on GrpclbLoadBalancer
temawi Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Forwarding and GracefulSwitch LBS to ignore deprecation
  • Loading branch information
@temawi
temawi committed Apr 10, 2023
commit 8d1b1321115910016174f9eff7e245af8596b3d5
4 changes: 2 additions & 2 deletions api/src/main/java/io/grpc/LoadBalancer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import com.google.common.base.MoreObjects;
import com.google.common.base.Objects;
import com.google.common.base.Preconditions;
import com.google.errorprone.annotations.InlineMe;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
Expand Down Expand Up @@ -133,7 +132,7 @@ public abstract class LoadBalancer {
* its return value.
*/
@Deprecated
@InlineMe(replacement = "acceptResolvedAddresses(resolvedAddresses)")
@SuppressWarnings("InlineMeSuggester")
public void handleResolvedAddresses(ResolvedAddresses resolvedAddresses) {
if (recursionCount++ == 0) {
// Note that the information about the addresses actually being accepted will be lost
Expand Down Expand Up @@ -398,6 +397,7 @@ public void handleSubchannelState(
* value.
*/
@Deprecated
@SuppressWarnings("InlineMeSuggester")
public boolean canHandleEmptyAddressListFromNameResolution() {
return false;
}
Expand Down
2 changes: 2 additions & 0 deletions core/src/main/java/io/grpc/util/ForwardingLoadBalancer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ public abstract class ForwardingLoadBalancer extends LoadBalancer {
protected abstract LoadBalancer delegate();

@Override
@SuppressWarnings("deprecation")
public void handleResolvedAddresses(ResolvedAddresses resolvedAddresses) {
delegate().handleResolvedAddresses(resolvedAddresses);
}
Expand All @@ -52,6 +53,7 @@ public void shutdown() {
}

@Override
@SuppressWarnings("deprecation")
public boolean canHandleEmptyAddressListFromNameResolution() {
return delegate().canHandleEmptyAddressListFromNameResolution();
}
Expand Down
1 change: 1 addition & 0 deletions core/src/main/java/io/grpc/util/GracefulSwitchLoadBalancer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
public final class GracefulSwitchLoadBalancer extends ForwardingLoadBalancer {
private final LoadBalancer defaultBalancer = new LoadBalancer() {
@Override
@SuppressWarnings("deprecation")
public void handleResolvedAddresses(ResolvedAddresses resolvedAddresses) {
// Most LB policies using this class will receive child policy configuration within the
// service config, so they are naturally calling switchTo() just before
Expand Down