services: handle malformed health-check config gracefully. #5416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a bad config will make the channel panic. According to @markdroth, gRPC C++ just ignores it. Here we will log a warning in addition.
larry-safran
requested review from
YifeiZhuang
and removed request for
carl-mastrangelo
YifeiZhuang
approved these changes
Jan 5, 2024
Member
|
I don't remember this conversation. Can you remind me of the context here? Are we talking about the health check config in service config? If so, it's not clear to me how it can be malformed, because invalid JSON would be rejected by the service config parser. |
Contributor
Author
|
After 5 years, the context has left my brain ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a bad config will make the channel panic. According to
@markdroth, gRPC C++ just ignores it. Here we will log a warning in
addition.