stub: ignore unary response msg if status is not OK for async server #6296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
requested changes
Oct 22, 2019
| .asRuntimeException(); | ||
| } | ||
| if (error != null) { | ||
| onError(error); |
Member
There was a problem hiding this comment.
This error is sent to the client. We should not send either of the two possible error values, as we don't want to send exceptions to clients for the application (it's bad practice that we don't want to encourage) and the other message doesn't make sense to the client.
What we should do instead is slightly unclear, but we can talk about it offline.
ST-DDT
reviewed
Oct 26, 2019
Contributor
ST-DDT
left a comment
ST-DDT
left a comment
There was a problem hiding this comment.
This will definitly help detecting usage flaws.
| call.sendMessage(response); | ||
| } else { | ||
| // delay the sendMessage() to onComplete()/onError() | ||
| unaryResponse = response; |
Contributor
There was a problem hiding this comment.
IMO this should throw an exception if the server sends multiple responses/overwrites the previous one.
| completed = true; | ||
|
|
||
| if (call.getMethodDescriptor().getType().serverSendsOneMessage()) { | ||
| Throwable error = null; |
Contributor
There was a problem hiding this comment.
This error should be logged to the server log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5969