POC: outbound protobuf zero-copy #7350
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outbound equivalent of grpc#7330. Protobuf doesn't support multiple ByteBuffers in this direction but I don't think that matters much since the outbound buffers are typically allocated/sized to fit the messages.
njhill
added a commit
to njhill/grpc-java
that referenced
this pull request
Aug 27, 2020
Variation on grpc#7350. Slightly bigger but I think the interface changes are cleaner, avoids "borrowing" a ByteBuffer and separately informing of bytes written. Not sure which approach is preferable.
njhill
added a commit
to njhill/grpc-java
that referenced
this pull request
Aug 27, 2020
Variation on grpc#7350. Slightly bigger but I think the interface changes are cleaner, avoids "borrowing" a ByteBuffer and separately informing of bytes written. Not sure which approach is preferable.
njhill
added a commit
to njhill/grpc-java
that referenced
this pull request
Aug 28, 2020
Variation on grpc#7350. Slightly bigger but I think the interface changes are cleaner, avoids "borrowing" a ByteBuffer and separately informing of bytes written. Not sure which approach is preferable.
njhill
added a commit
to njhill/grpc-java
that referenced
this pull request
Aug 28, 2020
Variation on grpc#7350. Slightly bigger but I think the interface changes are cleaner, avoids "borrowing" a ByteBuffer and separately informing of bytes written. Not sure which approach is preferable.
njhill
added a commit
to njhill/grpc-java
that referenced
this pull request
Aug 28, 2020
Variation on grpc#7350. Slightly bigger but I think the interface changes are cleaner, avoids "borrowing" a ByteBuffer and separately informing of bytes written. Not sure which approach is preferable.
Member
|
CC @voidzcy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outbound equivalent of #7330.
Protobuf doesn't support multiple
ByteBuffers in this direction but I don't think that matters much since the outbound buffers are typically allocated/sized to fit the messages.