Skip to content

Improve performance of batch operation serializer #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
murgatroid99 merged 1 commit into from
Mar 13, 2018
+8 −3
Merged

Improve performance of batch operation serializer #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Improve performance of batch operation serializer
  • Loading branch information
@drobertduke
drobertduke committed Mar 13, 2018
commit 8b8a4437e237619cad60005691aa0239eb0c86c0
11 changes: 8 additions & 3 deletions packages/grpc-native-core/src/client_interceptors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,9 +740,14 @@ function _areBatchRequirementsMet(batch_ops, completed_ops) {
var dependencies = _.flatMap(batch_ops, function(op) {
return OP_DEPENDENCIES[op] || [];
});
var dependencies_met = _.intersection(dependencies,
batch_ops.concat(completed_ops));
return _.isEqual(dependencies_met.sort(), dependencies.sort());
for (var i = 0; i < dependencies.length; i++) {
var required_dep = dependencies[i];
if (batch_ops.indexOf(required_dep) === -1 &&
completed_ops.indexOf(required_dep) === -1) {
return false;
}
}
return true;
}

/**
Expand Down