Skip to content

Adding initial node 10 support. #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolasnoble merged 10 commits into from
May 2, 2018
Merged

Adding initial node 10 support. #302

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9d1904f
Adding initial node 10 support.
nicolasnoble May 1, 2018
e358560
Building with node 10, because otherwise there's a weird issue, and I…
nicolasnoble May 1, 2018
5f47953
Installing nvm from kokoro scripts.
nicolasnoble May 1, 2018
582c171
Shuffling things around a bit better...
nicolasnoble May 1, 2018
c94718c
Let's double down on installing node 10...
nicolasnoble May 2, 2018
727e54e
Right. We need to install nvm into the docker image.
nicolasnoble May 2, 2018
d465566
More nvm love.
nicolasnoble May 2, 2018
c794c05
Merge branch 'v1.11.x' of https://github.com/grpc/grpc-node into node-10
nicolasnoble May 2, 2018
c5fbaf1
Reverting these...
nicolasnoble May 2, 2018
30310d7
Better this way...
nicolasnoble May 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Installing nvm from kokoro scripts.
  • Loading branch information
@nicolasnoble
nicolasnoble committed May 1, 2018
commit 5f47953c88ac9671e5e474630b640cf56b28b587
4 changes: 0 additions & 4 deletions packages/grpc-native-core/tools/run_tests/artifacts/build_artifact_node.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@
@rem See the License for the specific language governing permissions and
@rem limitations under the License.

powershell -c "& { iwr https://raw.githubusercontent.com/grumpycoders/nvm-ps/master/nvm.ps1 | iex }"

SET PATH=%APPDATA%\nvm-ps;%APPDATA%\nvm-ps\nodejs;%PATH%

call nvm install 10
call nvm use 10

Expand Down
5 changes: 3 additions & 2 deletions tools/release/kokoro.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@

@echo "Starting Windows build"

@rem https://github.com/mapbox/node-pre-gyp/issues/362
call npm install -g node-gyp
powershell -c "& { iwr https://raw.githubusercontent.com/grumpycoders/nvm-ps/master/nvm.ps1 | iex }"

SET PATH=%APPDATA%\nvm-ps;%APPDATA%\nvm-ps\nodejs;%PATH%

cd /d %~dp0
cd ..\..
Expand Down
5 changes: 3 additions & 2 deletions tools/release/kokoro.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# https://github.com/mapbox/node-pre-gyp/issues/362
npm install -g node-gyp
curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.11/install.sh | bash
export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"

set -ex
cd $(dirname $0)/../..
Expand Down