CHANGE: Function Declaration examples

[stefanooldeman]

No description provided.

[guidokessels]

var something = function() { ... }
is basically the same as
function something() { ...}

I think we should choose one format and stick to it.

I find this:

// Good
function outer() {

    var count = 10,
        name = "SpilGames",
        found = false,
        empty;

    function inner() {
        // code
    }

    // code that uses inner()
}

Much easier to read than this:

// Bad
function outer() {

    var count = 10,
        name = "SpilGames",
        found = false,
        empty,
        inner = function() {
            // code
        }

    // code that uses inner()
}

It adds extra indentation level and makes it harder to separate private function from private variables.

[stefanooldeman]

The point is not the declaration of the variable, but the spacing in the function. JSLint says there should be a space between function and () and {.

The second thing is that these two should be both valid:

function init () {
    that.hasInit = true;
}

and

var init = function () {
   that.hasInit = true;
}

The fact that the styleguide says: only one var statement should be used per scope, does not mean that the function body has to resided on the same line as the variable declaration (although this is done in all our modules currently and has always been a convention).