Skip to content

Fix: Correctly handle chat history in StreamContentAsync for function… #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gunpal5 merged 2 commits into from
Jul 21, 2025
Merged

Fix: Correctly handle chat history in StreamContentAsync for function… #58

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2ce891
Fix: Correctly handle chat history in StreamContentAsync for function…
RyanStanLin Jul 21, 2025
b2daca5
Merge branch 'main' into fix/57-streamcontent-ignore-funcs
gunpal5 Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions src/GenerativeAI/AiModels/ChatSession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,20 +173,28 @@ protected override List<Content> BeforeRegeneration(GenerateContentRequest origi
/// <inheritdoc />
public override async IAsyncEnumerable<GenerateContentResponse> StreamContentAsync(GenerateContentRequest request, [EnumeratorCancellation] CancellationToken cancellationToken = default)
{
var historyCountBeforeRequest = this.History.Count;
var sb = new StringBuilder();
await foreach (var response in base.StreamContentAsync(request,cancellationToken).ConfigureAwait(false))
await foreach (var response in base.StreamContentAsync(request, cancellationToken).ConfigureAwait(false))
{
if (cancellationToken.IsCancellationRequested)
yield break;

sb.Append(response.Text());
yield return response;
}

var lastRequestContent = request.Contents.Last();
var lastResponseContent = RequestExtensions.FormatGenerateContentInput(sb.ToString(), Roles.Model);

UpdateHistory(lastRequestContent, lastResponseContent);
var finalModelResponseContent = RequestExtensions.FormatGenerateContentInput(sb.ToString(), Roles.Model);
var userPromptContent = request.Contents
.Skip(historyCountBeforeRequest)
.FirstOrDefault(c => c.Role?.Equals(Roles.User, StringComparison.OrdinalIgnoreCase) == true &&
c.Parts.All(p => p.FunctionResponse == null));
if (userPromptContent != null)
{
UpdateHistory(userPromptContent, finalModelResponseContent);
}
else
{
this.LastResponseContent = finalModelResponseContent;
}
}

private void UpdateHistory(GenerateContentRequest request, GenerateContentResponse response)
Expand Down