Skip to content

Fix memory_space type alias in DerivField. Fixes #552#553

Merged
EmilyBourne merged 11 commits into
gyselax:develfrom
Quntized:fix-derivfield-memoryspace-142
Feb 24, 2026
Merged

Fix memory_space type alias in DerivField. Fixes #552#553
EmilyBourne merged 11 commits into
gyselax:develfrom
Quntized:fix-derivfield-memoryspace-142

Conversation

@Quntized

@Quntized Quntized commented Feb 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix incorrect memory_space type alias in DerivField. It was set to typename base_type::element_type (copy-paste error) instead of MemorySpace.

Please complete the checklist to ensure that all tasks are completed before marking your pull request as ready for review.

All Submissions

  • Have you ensured that all lines changed in this PR are justified by a comment found in the description ?
  • Have you updated the CHANGELOG.md ?
  • Have you linked any issues that should be closed when this PR is merged (using closing keywords) ?
  • Have you checked that the AUTHORS file is up to date ?
  • Have you checked that the copyright information in the LICENCE file is up to date (including dates) ?
  • Do you follow the conventions specified in our coding standards ?

New Feature Submissions

  • Have you added tests for the new functionalities ?
  • Have you documented the new functionalities:
    • API documentation describing the available methods, when each should be used and how to use them ?
    • User-friendly documentation in README files (which may link to the API documentation).
    • If the new functionality is non-trivial to use, provide a tutorial or example ? (optional)

Changes to Existing Features

  • Have you checked that existing tests cover all code after the changes ?
  • Have you checked that existing tests are still passing ?
  • Have you checked that the existing documentation is still accurate (API and README files) ?

Changes to the CI

  • Have you made the same changes to both the GitHub CI and the GitLab CI (for the private fork) ?

tpadioleau
tpadioleau requested changes Feb 24, 2026
View reviewed changes

@tpadioleau tpadioleau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Just a minor change in the fix.

Also could you complete the section "All Submissions" in the checklist ? Don't hesitate if you have questions.

Comment thread src/data_types/derivative_field.hpp Outdated
@Quntized

Quntized commented Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

Updated the typename removal as suggested and corrected the checklist. Ready for re-review.

@tpadioleau

tpadioleau commented Feb 24, 2026

Copy link
Copy Markdown
Member

Updated the typename removal as suggested and corrected the checklist. Ready for re-review.

As it is a bug fix, do you mind adding a changelog entry in the section "Fixed" ?

@Quntized

Quntized commented Feb 24, 2026 via email

Copy link
Copy Markdown
Contributor Author

@EmilyBourne

EmilyBourne commented Feb 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@Quntized thank you very much for finding and fixing this bug.
For legal reasons it is helpful for us to have a list of everyone who has contributed to the repository no matter how minor their contribution. Would you mind adding yourself to the AUTHORS file? If you pull the latest changes from the devel branch you should find a new section to list contributors who have contributed bug fixes and other minor changes

gyselalibxx/AUTHORS

Lines 66 to 69 in 8ad19b5

## Minor contributions
We would also like to thank contributors who have provided bug fixes and minor contributions:
-

@Quntized Quntized force-pushed the fix-derivfield-memoryspace-142 branch from fe1cf54 to e0622c4 Compare February 24, 2026 11:36
@Quntized

Quntized commented Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

Thanks,

Resolved merge conflicts. Added myself to the Minor contributions section in AUTHORS and added a changelog entry in the Fixed section. Ready for re-review.

@Quntized

Quntized commented Feb 24, 2026 via email

Copy link
Copy Markdown
Contributor Author

tpadioleau
tpadioleau reviewed Feb 24, 2026
View reviewed changes
Comment thread AUTHORS Outdated
EmilyBourne
EmilyBourne reviewed Feb 24, 2026
View reviewed changes
Comment thread CHANGELOG.md
@Quntized

Quntized commented Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

Applied @EmilyBourne 's formatting suggestion and added myself to AUTHORS. All feedback addressed — ready for re-review. Thanks!

@Quntized Quntized force-pushed the fix-derivfield-memoryspace-142 branch from e59fce4 to 2a11085 Compare February 24, 2026 13:13
@codecov

codecov Bot commented Feb 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Quntized

Quntized commented Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

@tpadioleau All feedback addressed. Ready for re-review when you get a chance. Thanks!

@EmilyBourne EmilyBourne merged commit a9c23aa into gyselax:devel Feb 24, 2026
25 of 27 checks passed
EmilyBourne pushed a commit that referenced this pull request Mar 5, 2026
@Quntized @tpadioleau @EmilyBourne
Fix memory_space type alias in DerivField. Fixes #552 (#553)
0b356d3 
Fix incorrect `memory_space` type alias in `DerivField`. It was set to
`typename base_type::element_type` (copy-paste error) instead of
`MemorySpace`.

---------

Co-authored-by: Thomas Padioleau <thomas.padioleau@cea.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmilyBourne EmilyBourne EmilyBourne approved these changes

@tpadioleau tpadioleau tpadioleau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Quntized @tpadioleau @EmilyBourne