Skip to content

use provided exec_space#586

Merged
EmilyBourne merged 1 commit into
gyselax:develfrom
Quntized:fix/exec_space
Mar 9, 2026
Merged

use provided exec_space#586
EmilyBourne merged 1 commit into
gyselax:develfrom
Quntized:fix/exec_space

Conversation

@Quntized

@Quntized Quntized commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

Just a minor exec_space replacement instead of ExecSpace()

Please complete the checklist to ensure that all tasks are completed before marking your pull request as ready for review.

All Submissions

  • Have you ensured that all lines changed in this PR are justified by a comment found in the description ?
  • Have you updated the CHANGELOG.md ?
  • Have you linked any issues that should be closed when this PR is merged (using closing keywords) ?
  • Have you checked that the AUTHORS file is up to date ?
  • Have you checked that the copyright information in the LICENCE file is up to date (including dates) ?
  • Do you follow the conventions specified in our coding standards ?

New Feature Submissions

  • Have you added tests for the new functionalities ?
  • Have you documented the new functionalities:
    • API documentation describing the available methods, when each should be used and how to use them ?
    • User-friendly documentation in README files (which may link to the API documentation).
    • If the new functionality is non-trivial to use, provide a tutorial or example ? (optional)

Changes to Existing Features

  • Have you checked that existing tests cover all code after the changes ?
  • Have you checked that existing tests are still passing ?
  • Have you checked that the existing documentation is still accurate (API and README files) ?

Changes to the CI

  • Have you made the same changes to both the GitHub CI and the GitLab CI (for the private fork) ?

@Quntized Quntized had a problem deploying to GitLab GPU trigger March 9, 2026 07:26 — with GitHub Actions Failure

@tpadioleau tpadioleau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, thanks!

Beware that for now we only use and test the default execution spaces. There may still be some bugs of asynchronism like this one elsewhere.

@EmilyBourne EmilyBourne merged commit 61e498e into gyselax:devel Mar 9, 2026
23 of 26 checks passed
EmilyBourne pushed a commit that referenced this pull request Mar 18, 2026
Just a minor exec_space replacement instead of ExecSpace()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants