Skip to content

allow speed from get #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
h2non merged 2 commits into from
Feb 20, 2022
Merged

allow speed from get #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f549b94
allow speed from get
vaibsharma Feb 16, 2022
3c9eafe
updating the version to use effor param in libvips
vaibsharma Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ ARG GOLANG_VERSION=1.17
FROM golang:${GOLANG_VERSION}-buster as builder

ARG IMAGINARY_VERSION=dev
ARG LIBVIPS_VERSION=8.10.0
ARG LIBVIPS_VERSION=8.12.2
ARG GOLANGCILINT_VERSION=1.29.0

# Installs libvips + required libraries
Expand Down
2 changes: 2 additions & 0 deletions options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ type ImageOptions struct {
Color []uint8
Background []uint8
Interlace bool
Speed int
Extend bimg.Extend
Gravity bimg.Gravity
Colorspace bimg.Interpretation
Expand Down Expand Up @@ -144,6 +145,7 @@ func BimgOptions(o ImageOptions) bimg.Options {
Rotate: bimg.Angle(o.Rotate),
Interlace: o.Interlace,
Palette: o.Palette,
Speed: o.Speed,
}

if len(o.Background) != 0 {
Expand Down
6 changes: 6 additions & 0 deletions params.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ var paramTypeCoercions = map[string]Coercion{
"interlace": coerceInterlace,
"aspectratio": coerceAspectRatio,
"palette": coercePalette,
"speed": coerceSpeed,
}

func coerceTypeInt(param interface{}) (int, error) {
Expand Down Expand Up @@ -350,6 +351,11 @@ func coercePalette(io *ImageOptions, param interface{}) (err error) {
return err
}

func coerceSpeed(io *ImageOptions, param interface{}) (err error) {
io.Speed, err = coerceTypeInt(param)
return err
}

func buildParamsFromOperation(op PipelineOperation) (ImageOptions, error) {
var options ImageOptions

Expand Down